Re: [PATCH v2] pstore: Support already existing reserved-memory node

2022-04-19 Thread Detlev Casanova
Hi Daniel, On Tuesday, April 19, 2022 12:14:07 P.M. EDT Daniel Golle wrote: > Hi Detlev, > > On Tue, Apr 19, 2022 at 09:58:00AM -0400, Detlev Casanova wrote: > > Hey Daniel, > > > > I see that the node is called ramoops@0x42ff. We usually don't set the > > 0x in device tree nodes, and

Re: [PATCH v2] pstore: Support already existing reserved-memory node

2022-04-19 Thread Daniel Golle
Hi Detlev, On Tue, Apr 19, 2022 at 09:58:00AM -0400, Detlev Casanova wrote: > Hey Daniel, > > I see that the node is called ramoops@0x42ff. We usually don't set the 0x > in device tree nodes, and that's why the fdt_add_subnode function doesn't see > it and add ramoops@42ff (it just

Re: [PATCH v2] pstore: Support already existing reserved-memory node

2022-04-19 Thread Detlev Casanova
Hey Daniel, I see that the node is called ramoops@0x42ff. We usually don't set the 0x in device tree nodes, and that's why the fdt_add_subnode function doesn't see it and add ramoops@42ff (it just compares the text). For Linux, both nodes are the same and it complains. I think the

Re: [PATCH v2] pstore: Support already existing reserved-memory node

2022-04-19 Thread Detlev Casanova
Hi Daniel, The patch only checks the existence of the reserved-memory node. I guess that before, adding the reserved-memory node failed and so nothing else was happening. Now, the node is found and then, it adds the ramoops subnode to it, making it double because it is already there in your

Re: [PATCH v2] pstore: Support already existing reserved-memory node

2022-04-18 Thread Daniel Golle
Hi Detlev, On Mon, Apr 18, 2022 at 02:46:21PM -0400, Detlev Casanova wrote: > Hi Daniel, > > The patch only checks the existence of the reserved-memory node. > > I guess that before, adding the reserved-memory node failed and so nothing > else was happening. Now, the node is found and then, it

Re: [PATCH v2] pstore: Support already existing reserved-memory node

2022-04-11 Thread Daniel Golle
Hi Detlev, I've recently tried to update U-Boot from 2022.01 to 2022.04 and noticed a regression introduced by the commit below. While the unwanted error message ("Add 'reserved-memory' node failed: FDT_ERR_EXISTS") no longer appears, I now see a lengthy kernel stack trace in Linux instead: ...

Re: [PATCH v2] pstore: Support already existing reserved-memory node

2022-02-14 Thread Tom Rini
On Mon, Feb 07, 2022 at 11:02:30AM -0500, Detlev Casanova wrote: > The pstore command tries to create a reserved-memory node but fails if > it is already present with: > > Add 'reserved-memory' node failed: FDT_ERR_EXISTS > > This patch creates the node only if it does not exist and adapts

[PATCH v2] pstore: Support already existing reserved-memory node

2022-02-07 Thread Detlev Casanova
The pstore command tries to create a reserved-memory node but fails if it is already present with: Add 'reserved-memory' node failed: FDT_ERR_EXISTS This patch creates the node only if it does not exist and adapts the reg values sizes depending on already present #address-cells and