Re: [PATCH v2] tools: copyfile: use 64k instead of 512 buffer

2024-03-21 Thread Dragan Simic
Hello Ahelenia, Please see my comments below. On 2024-03-21 19:29, Ahelenia Ziemiańska wrote: This is a trivial but significant optimisation: s/optimisation/optimization/ mkimage took >200ms (and 49489 writes (of which 49456 512)), now it takes 110ms (and 419 writes (of which 386

[PATCH v2] tools: copyfile: use 64k instead of 512 buffer

2024-03-21 Thread Ahelenia Ziemiańska
This is a trivial but significant optimisation: mkimage took >200ms (and 49489 writes (of which 49456 512)), now it takes 110ms (and 419 writes (of which 386 64k)). sendfile is much more appropriate for this and is done in one syscall, but doesn't bring any significant speedups over 64k r/w