Re: [PATCH v2] tpm: display warning if using gpio reset with TPM

2024-04-17 Thread Ilias Apalodimas
Hi Tim! > > > > > > > > > > The current logic expects a reset gpio and bails out if it cannot get > > > > > it with a (questionable) goto statement. > > > > > > > > > > You want to invert that logic, and expect no gpio, but only if there > > > > > is > > > > > one you want to warn. > > > > > > >

Re: [PATCH v2] tpm: display warning if using gpio reset with TPM

2024-04-17 Thread Tim Harvey
On Wed, Apr 17, 2024 at 12:01 AM Ilias Apalodimas wrote: > > On Wed, 17 Apr 2024 at 09:48, Miquel Raynal wrote: > > > > Hi Ilias, > > > > ilias.apalodi...@linaro.org wrote on Wed, 17 Apr 2024 08:40:14 +0300: > > > > > Hi Miquel > > > > > > On Mon, 8 Apr 2024 at 10:23, Miquel Raynal > > >

Re: [PATCH v2] tpm: display warning if using gpio reset with TPM

2024-04-17 Thread Ilias Apalodimas
On Wed, 17 Apr 2024 at 09:48, Miquel Raynal wrote: > > Hi Ilias, > > ilias.apalodi...@linaro.org wrote on Wed, 17 Apr 2024 08:40:14 +0300: > > > Hi Miquel > > > > On Mon, 8 Apr 2024 at 10:23, Miquel Raynal > > wrote: > > > > > > Hello, > > > > > > ilias.apalodi...@linaro.org wrote on Thu, 28

Re: [PATCH v2] tpm: display warning if using gpio reset with TPM

2024-04-17 Thread Miquel Raynal
Hi Ilias, ilias.apalodi...@linaro.org wrote on Wed, 17 Apr 2024 08:40:14 +0300: > Hi Miquel > > On Mon, 8 Apr 2024 at 10:23, Miquel Raynal wrote: > > > > Hello, > > > > ilias.apalodi...@linaro.org wrote on Thu, 28 Mar 2024 09:08:37 +0200: > > > > > Thanks Tim > > > > > > On Thu, 28 Mar 2024

Re: [PATCH v2] tpm: display warning if using gpio reset with TPM

2024-04-16 Thread Ilias Apalodimas
Hi Miquel On Mon, 8 Apr 2024 at 10:23, Miquel Raynal wrote: > > Hello, > > ilias.apalodi...@linaro.org wrote on Thu, 28 Mar 2024 09:08:37 +0200: > > > Thanks Tim > > > > On Thu, 28 Mar 2024 at 00:12, Tim Harvey wrote: > > > > > > Instead of displaying what looks like an error message if a > > >

Re: [PATCH v2] tpm: display warning if using gpio reset with TPM

2024-04-08 Thread Miquel Raynal
Hello, ilias.apalodi...@linaro.org wrote on Thu, 28 Mar 2024 09:08:37 +0200: > Thanks Tim > > On Thu, 28 Mar 2024 at 00:12, Tim Harvey wrote: > > > > Instead of displaying what looks like an error message if a > > gpio-reset dt prop is missing for a TPM display a warning that > > having a gpio

Re: [PATCH v2] tpm: display warning if using gpio reset with TPM

2024-03-28 Thread Ilias Apalodimas
Thanks Tim On Thu, 28 Mar 2024 at 00:12, Tim Harvey wrote: > > Instead of displaying what looks like an error message if a > gpio-reset dt prop is missing for a TPM display a warning that > having a gpio reset on a TPM should not be used for a secure production > device. > > TCG TIS spec [1]

[PATCH v2] tpm: display warning if using gpio reset with TPM

2024-03-27 Thread Tim Harvey
Instead of displaying what looks like an error message if a gpio-reset dt prop is missing for a TPM display a warning that having a gpio reset on a TPM should not be used for a secure production device. TCG TIS spec [1] says: "The TPM_Init (LRESET#/SPI_RST#) signal MUST be connected to the