Re: [PATCH v2 07/17] x86: apl: Drop the I2C config in FSP-S

2020-02-03 Thread Bin Meng
On Tue, Feb 4, 2020 at 8:20 AM Simon Glass wrote: > > This config is not actually used here and in U-Boot it seems better to set > this using the device tree for each individual controller. The monolithic > config of the FSP-S is only necessary if the FSP is actually configuring > something, but

[PATCH v2 07/17] x86: apl: Drop the I2C config in FSP-S

2020-02-03 Thread Simon Glass
This config is not actually used here and in U-Boot it seems better to set this using the device tree for each individual controller. The monolithic config of the FSP-S is only necessary if the FSP is actually configuring something, but here it is not. The FSP-S does enable/disable the various