Re: [PATCH v2 15/15] x86: qemu: Remove dead code

2020-09-01 Thread Andy Shevchenko
On Tue, Sep 01, 2020 at 10:05:00AM +0300, Andy Shevchenko wrote: > On Tue, Sep 01, 2020 at 02:15:32PM +0800, Bin Meng wrote: > > On Thu, Aug 20, 2020 at 6:02 PM Andy Shevchenko > > wrote: ... > > > -obj-y += start.o > > > > Unfortunately this does not build. > > > > We possibly need to fix

Re: [PATCH v2 15/15] x86: qemu: Remove dead code

2020-09-01 Thread Andy Shevchenko
On Tue, Sep 01, 2020 at 02:15:32PM +0800, Bin Meng wrote: > Hi Andy, > > On Thu, Aug 20, 2020 at 6:02 PM Andy Shevchenko > wrote: > > > > start.S does nothing and can be safely removed. Makefile is still being used > > by the build system, so simply drop the rule from it. > > > > Signed-off-by:

Re: [PATCH v2 15/15] x86: qemu: Remove dead code

2020-09-01 Thread Bin Meng
Hi Andy, On Thu, Aug 20, 2020 at 6:02 PM Andy Shevchenko wrote: > > start.S does nothing and can be safely removed. Makefile is still being used > by the build system, so simply drop the rule from it. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Simon Glass > --- > v2: added Rb tag(s) > >

Re: [PATCH v2 15/15] x86: qemu: Remove dead code

2020-08-31 Thread Bin Meng
On Thu, Aug 20, 2020 at 6:02 PM Andy Shevchenko wrote: > > start.S does nothing and can be safely removed. Makefile is still being used > by the build system, so simply drop the rule from it. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Simon Glass > --- > v2: added Rb tag(s) > >

[PATCH v2 15/15] x86: qemu: Remove dead code

2020-08-20 Thread Andy Shevchenko
start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it. Signed-off-by: Andy Shevchenko Reviewed-by: Simon Glass --- v2: added Rb tag(s) board/emulation/qemu-x86/Makefile | 2 -- board/emulation/qemu-x86/start.S | 8