Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Andre Przywara
On Mon, 5 Jul 2021 12:45:59 +0200 Marek Vasut wrote: Hi, > On 7/5/21 11:18 AM, Bin Meng wrote: > > Hi Andre, > > > > On Mon, Jul 5, 2021 at 5:07 PM Andre Przywara > > wrote: > >> > >> On Mon, 5 Jul 2021 16:38:29 +0800 > >> Bin Meng wrote: > >> > >> Hi, > >> > >>> On Mon, Jul 5, 2021 at 4

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Marek Vasut
On 7/5/21 11:18 AM, Bin Meng wrote: Hi Andre, On Mon, Jul 5, 2021 at 5:07 PM Andre Przywara wrote: On Mon, 5 Jul 2021 16:38:29 +0800 Bin Meng wrote: Hi, On Mon, Jul 5, 2021 at 4:19 PM Marek Vasut wrote: On 7/5/21 10:04 AM, Bin Meng wrote: On Sat, Apr 17, 2021 at 10:21 PM Samuel Hollan

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Marek Vasut
On 7/5/21 10:38 AM, Bin Meng wrote: On Mon, Jul 5, 2021 at 4:19 PM Marek Vasut wrote: On 7/5/21 10:04 AM, Bin Meng wrote: On Sat, Apr 17, 2021 at 10:21 PM Samuel Holland wrote: Resetting an XHCI controller inside xhci_register undoes any register setup performed by the platform driver. And

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Bin Meng
Hi Andre, On Mon, Jul 5, 2021 at 5:07 PM Andre Przywara wrote: > > On Mon, 5 Jul 2021 16:38:29 +0800 > Bin Meng wrote: > > Hi, > > > On Mon, Jul 5, 2021 at 4:19 PM Marek Vasut wrote: > > > > > > On 7/5/21 10:04 AM, Bin Meng wrote: > > > > On Sat, Apr 17, 2021 at 10:21 PM Samuel Holland > > >

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Andre Przywara
On Mon, 5 Jul 2021 16:38:29 +0800 Bin Meng wrote: Hi, > On Mon, Jul 5, 2021 at 4:19 PM Marek Vasut wrote: > > > > On 7/5/21 10:04 AM, Bin Meng wrote: > > > On Sat, Apr 17, 2021 at 10:21 PM Samuel Holland > > > wrote: > > >> > > >> Resetting an XHCI controller inside xhci_register undoes a

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Bin Meng
On Mon, Jul 5, 2021 at 4:19 PM Marek Vasut wrote: > > On 7/5/21 10:04 AM, Bin Meng wrote: > > On Sat, Apr 17, 2021 at 10:21 PM Samuel Holland wrote: > >> > >> Resetting an XHCI controller inside xhci_register undoes any register > >> setup performed by the platform driver. And at least on the All

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Marek Vasut
On 7/5/21 10:04 AM, Bin Meng wrote: On Sat, Apr 17, 2021 at 10:21 PM Samuel Holland wrote: Resetting an XHCI controller inside xhci_register undoes any register setup performed by the platform driver. And at least on the Allwinner H6, resetting the XHCI controller also resets the PHY, which pr

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-07-05 Thread Bin Meng
On Sat, Apr 17, 2021 at 10:21 PM Samuel Holland wrote: > > Resetting an XHCI controller inside xhci_register undoes any register > setup performed by the platform driver. And at least on the Allwinner > H6, resetting the XHCI controller also resets the PHY, which prevents > the controller from wor

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-04-21 Thread Andre Przywara
On Wed, 21 Apr 2021 08:36:26 -0500 Samuel Holland wrote: Hi, > On 4/21/21 5:36 AM, Andre Przywara wrote: > > On Sat, 17 Apr 2021 09:20:57 -0500 > > Samuel Holland wrote: > > > > Hi, > > > >> Resetting an XHCI controller inside xhci_register undoes any register > >> setup performed by the pl

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-04-21 Thread Samuel Holland
On 4/21/21 5:36 AM, Andre Przywara wrote: > On Sat, 17 Apr 2021 09:20:57 -0500 > Samuel Holland wrote: > > Hi, > >> Resetting an XHCI controller inside xhci_register undoes any register >> setup performed by the platform driver. And at least on the Allwinner >> H6, resetting the XHCI controller

Re: [PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-04-21 Thread Andre Przywara
On Sat, 17 Apr 2021 09:20:57 -0500 Samuel Holland wrote: Hi, > Resetting an XHCI controller inside xhci_register undoes any register > setup performed by the platform driver. And at least on the Allwinner > H6, resetting the XHCI controller also resets the PHY, which prevents > the controller fr

[PATCH v2 2/4] usb: xhci-pci: Move reset logic out of XHCI core

2021-04-17 Thread Samuel Holland
Resetting an XHCI controller inside xhci_register undoes any register setup performed by the platform driver. And at least on the Allwinner H6, resetting the XHCI controller also resets the PHY, which prevents the controller from working. That means the controller must be taken out of reset before