Re: [PATCH v2 4/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568

2022-01-13 Thread Alper Nebi Yasak
On 12/01/2022 05:03, 赵仪峰 wrote: > The Synopsys DWC MSHC for RK3568 and RK3588 need config > DWCMSHC_EMMC_CONTROL.bit0 = 1 (CARD_IS_EMMC) > to enable Data Strobe pin for HS400 and HS400ES. > > reference code: > #define DWCMSHC_EMMC_CONTROL 0x52c > #define DWCMSHC_CARD_IS_EMMC BIT(0) > > /* set

Re: [PATCH v2 4/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568

2022-01-11 Thread 赵仪峰
Hi Alper, The Synopsys DWC MSHC for RK3568 and RK3588 need config DWCMSHC_EMMC_CONTROL.bit0 = 1 (CARD_IS_EMMC) to enable Data Strobe pin for HS400 and HS400ES. reference code: #define DWCMSHC_EMMC_CONTROL 0x52c #define DWCMSHC_CARD_IS_EMMC BIT(0) /* set CARD_IS_EMMC bit to enable Data Strobe

[PATCH v2 4/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568

2022-01-11 Thread Alper Nebi Yasak
On RK3568, a register bit must be set to enable Enhanced Strobe. However, it appears that the address of this register may differ from vendor to vendor and should be read from the underlying MMC IP. Let the Rockchip SDHCI driver read this address and set the relevant bit when Enhanced Strobe