Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-21 Thread Marek Vasut
On 3/19/24 10:17 PM, Janne Grunau wrote: Hi, sorry for the abysmal delay in response. On Mon, Mar 18, 2024 at 03:17:33PM +0100, Marek Vasut wrote: On 3/18/24 8:33 AM, Janne Grunau wrote: +static int usb_blocklist_parse_error(const char *blocklist, size_t pos) +{ +

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-19 Thread Janne Grunau
On Mon, Mar 18, 2024 at 03:17:33PM +0100, Marek Vasut wrote: > On 3/18/24 8:33 AM, Janne Grunau wrote: > > > +static int usb_blocklist_parse_error(const char *blocklist, size_t pos) > > +{ > > + printf("usb_blocklist parse error at char %zu in \"%s\"\n", pos, > > +

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-18 Thread Marek Vasut
On 3/18/24 8:33 AM, Janne Grunau wrote: +static int usb_blocklist_parse_error(const char *blocklist, size_t pos) +{ + printf("usb_blocklist parse error at char %zu in \"%s\"\n", pos, + blocklist); + return 0; This could be static void without return 0 at the end.

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-18 Thread Janne Grunau
Hej, On Sun, Mar 17, 2024, at 22:39, E Shattow wrote: > Should be usb_denylist, since "block devices" is ambiguous meaning if > it is a list of data chunks (blocks) or if it blocks (deny). There is > no question what a denylist is. I briefly thought of that concluded that the spelling

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-18 Thread Janne Grunau
On Mon, Mar 18, 2024, at 06:06, Marek Vasut wrote: > On 3/17/24 7:15 PM, Janne Grunau wrote: >> Hej, > > Hi, > >> On Sun, Mar 17, 2024, at 17:18, Marek Vasut wrote: >>> On 3/17/24 12:07 PM, Janne Grunau via B4 Relay wrote: From: Janne Grunau Add the environment variable

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-17 Thread Marek Vasut
On 3/17/24 7:15 PM, Janne Grunau wrote: Hej, Hi, On Sun, Mar 17, 2024, at 17:18, Marek Vasut wrote: On 3/17/24 12:07 PM, Janne Grunau via B4 Relay wrote: From: Janne Grunau Add the environment variable "usb_blocklist" to prevent USB devices listed in it from being used. This allows to

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-17 Thread E Shattow
Should be usb_denylist, since "block devices" is ambiguous meaning if it is a list of data chunks (blocks) or if it blocks (deny). There is no question what a denylist is. On Sun, Mar 17, 2024 at 4:07 AM Janne Grunau via B4 Relay wrote: > > From: Janne Grunau > > Add the environment variable

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-17 Thread Janne Grunau
Hej, On Sun, Mar 17, 2024, at 17:18, Marek Vasut wrote: > On 3/17/24 12:07 PM, Janne Grunau via B4 Relay wrote: >> From: Janne Grunau >> >> Add the environment variable "usb_blocklist" to prevent USB devices >> listed in it from being used. This allows to ignore devices which >> trigger bugs in

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-17 Thread Marek Vasut
On 3/17/24 12:07 PM, Janne Grunau via B4 Relay wrote: From: Janne Grunau Add the environment variable "usb_blocklist" to prevent USB devices listed in it from being used. This allows to ignore devices which trigger bugs in u-boot's USB stack or are undesirable for other reasons. Devices

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-17 Thread Marek Vasut
On 3/17/24 12:34 PM, Janne Grunau wrote: Hej, On Sun, Mar 17, 2024, at 12:07, Janne Grunau via B4 Relay wrote: From: Janne Grunau Add the environment variable "usb_blocklist" to prevent USB devices listed in it from being used. This allows to ignore devices which trigger bugs in u-boot's USB

Re: [PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-17 Thread Janne Grunau
Hej, On Sun, Mar 17, 2024, at 12:07, Janne Grunau via B4 Relay wrote: > From: Janne Grunau > > Add the environment variable "usb_blocklist" to prevent USB devices > listed in it from being used. This allows to ignore devices which > trigger bugs in u-boot's USB stack or are undesirable for other

[PATCH v2 4/6] usb: Add environment based device blocklist

2024-03-17 Thread Janne Grunau via B4 Relay
From: Janne Grunau Add the environment variable "usb_blocklist" to prevent USB devices listed in it from being used. This allows to ignore devices which trigger bugs in u-boot's USB stack or are undesirable for other reasons. Devices emulating keyboards are one example. U-boot currently supports