Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-30 Thread Mathieu Othacehe
Hey, > And see if it fixes Ethernet on the board? Yes, it works! That allowed me to check that netboot was working as well on my patch. Thanks, Mathieu

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-30 Thread Mathieu Othacehe
> I am based on latest master 6faba41927bd (tag: v2024.04-rc1) That was it. I rebased from 043ca8c8a9b to 6faba41927bd and I now have the same behaviour as you. I cannot find which commit fixed the situation in that interval though. Preparing the v4, Thanks, Mathieu

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-30 Thread Primoz Fiser
Hi Mathieu, On 30. 01. 24 14:37, Mathieu Othacehe wrote: > >> I am based on latest master 6faba41927bd (tag: v2024.04-rc1) > > That was it. I rebased from 043ca8c8a9b to 6faba41927bd and I now have > the same behaviour as you. I cannot find which commit fixed the > situation in that interval

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-30 Thread Mathieu Othacehe
> And what awk do you both have? environment.h is generated via > scripts/env2string.awk On my side: mathieu@meije ~/u-boot [env]$ awk --version GNU Awk 5.2.1, API 3.2, PMA Avon 8-g1 and I have a similar result with: mathieu@FRMONPC1176:~$ awk --version GNU Awk 5.0.1, API: 2.0 (GNU MPFR

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-30 Thread Primoz Fiser
Hi Mathieu, On 30. 01. 24 13:49, Mathieu Othacehe wrote: > > Hey, > >> Can you re-check, please? >> >> Maybe check your include/generated/environment.h? > > Thanks for checking. It is strange that you do not reproduce that one. > > My include/generated/environment.h looks like: > >

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-30 Thread Tom Rini
On Tue, Jan 30, 2024 at 01:49:26PM +0100, Mathieu Othacehe wrote: > > Hey, > > > Can you re-check, please? > > > > Maybe check your include/generated/environment.h? > > Thanks for checking. It is strange that you do not reproduce that one. > > My include/generated/environment.h looks like: >

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-30 Thread Mathieu Othacehe
Hey, > Can you re-check, please? > > Maybe check your include/generated/environment.h? Thanks for checking. It is strange that you do not reproduce that one. My include/generated/environment.h looks like: --8<---cut here---start->8--- #define

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-30 Thread Mathieu Othacehe
Hello, > Please remove findfdt script. > > Not needed when you set fdt_file to CONFIG_DEFAULT_FDT_FILE above. The reason I used findfdt is that CONFIG_DEFAULT_FDT_FILE is a string so, we end up with: --8<---cut here---start->8--- fdt_file="oftree"

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-30 Thread Primoz Fiser
Hi Mathieu, On 30. 01. 24 10:43, Mathieu Othacehe wrote: > > Hello, > >> Please remove findfdt script. >> >> Not needed when you set fdt_file to CONFIG_DEFAULT_FDT_FILE above. > > The reason I used findfdt is that CONFIG_DEFAULT_FDT_FILE is a string > so, we end up with: > >

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-29 Thread Primoz Fiser
Hi Mathieu, thanks for fixing my remarks. Here are just a few left for v4. On 25. 01. 24 17:45, Mathieu Othacehe wrote: > Add initial support for the PHYTEC phyBOARD-Segin-i.MX93 board based on > the PHYTEC phyCORE-i.MX93 SoM. > > Supported features: > - 1GB LPDDR4 RAM > - eMMC > - external

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-25 Thread Fabio Estevam
On Thu, Jan 25, 2024 at 1:45 PM Mathieu Othacehe wrote: > +ipaddr=192.168.3.11 > +serverip=192.168.3.10 > +netmask=255.255.255.0 Please remove these hardcoded IP addresses.

[PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-25 Thread Mathieu Othacehe
Add initial support for the PHYTEC phyBOARD-Segin-i.MX93 board based on the PHYTEC phyCORE-i.MX93 SoM. Supported features: - 1GB LPDDR4 RAM - eMMC - external SD - debug UART - watchdog Signed-off-by: Mathieu Othacehe --- Hello, This new revision fixes the remarks of Primoz. It uses