Re: [PATCH v3 03/10] arm: mvebu: clearfog: initial ClearFog Base variant

2020-01-22 Thread Baruch Siach
Hi Joel, On Wed, Jan 22, 2020 at 07:28:51PM +, Joel Johnson wrote: > On January 22, 2020 10:32:58 AM UTC, Baruch Siach wrote: > >On Wed, Jan 22 2020, Joel Johnson wrote: > >> On 2020-01-21 10:49, Baruch Siach wrote: > >>> On Tue, Jan 21, 2020 at 10:32:17AM -0700, Joel Johnson wrote: > Ad

Re: [PATCH v3 03/10] arm: mvebu: clearfog: initial ClearFog Base variant

2020-01-22 Thread Stefan Roese
On 22.01.20 20:28, Joel Johnson wrote: It probably makes more sense to reverse the order of ORed conditions: if (IS_ENABLED(TARGET_CLEARFOG_BASE) || sr_product_is(&cf_tlv_data, "Clearfog Base")) IS_ENABLED() is evaluated at build time. When it is true, the com

Re: [PATCH v3 03/10] arm: mvebu: clearfog: initial ClearFog Base variant

2020-01-22 Thread Joel Johnson
On January 22, 2020 10:32:58 AM UTC, Baruch Siach wrote: >Hi Joel, > >On Wed, Jan 22 2020, Joel Johnson wrote: >> On 2020-01-21 10:49, Baruch Siach wrote: >>> On Tue, Jan 21, 2020 at 10:32:17AM -0700, Joel Johnson wrote: Add a unique entry for ClearFog Base variant, reflected in the >board

Re: [PATCH v3 03/10] arm: mvebu: clearfog: initial ClearFog Base variant

2020-01-22 Thread Baruch Siach
Hi Joel, On Wed, Jan 22 2020, Joel Johnson wrote: > On 2020-01-21 10:49, Baruch Siach wrote: >> On Tue, Jan 21, 2020 at 10:32:17AM -0700, Joel Johnson wrote: >>> Add a unique entry for ClearFog Base variant, reflected in the board >>> name and adjusted SerDes topology. >>> >>> Signed-off-by: Joel

Re: [PATCH v3 03/10] arm: mvebu: clearfog: initial ClearFog Base variant

2020-01-21 Thread Joel Johnson
On 2020-01-21 10:49, Baruch Siach wrote: Hi Joel, On Tue, Jan 21, 2020 at 10:32:17AM -0700, Joel Johnson wrote: Add a unique entry for ClearFog Base variant, reflected in the board name and adjusted SerDes topology. Signed-off-by: Joel Johnson --- v2 changes: - reworked based on Baruch's

Re: [PATCH v3 03/10] arm: mvebu: clearfog: initial ClearFog Base variant

2020-01-21 Thread Baruch Siach
Hi Joel, On Tue, Jan 21, 2020 at 10:32:17AM -0700, Joel Johnson wrote: > Add a unique entry for ClearFog Base variant, reflected in the board > name and adjusted SerDes topology. > > Signed-off-by: Joel Johnson > > --- > > v2 changes: > - reworked based on Baruch's run-time TLV EEPROM detect

[PATCH v3 03/10] arm: mvebu: clearfog: initial ClearFog Base variant

2020-01-21 Thread Joel Johnson
Add a unique entry for ClearFog Base variant, reflected in the board name and adjusted SerDes topology. Signed-off-by: Joel Johnson --- v2 changes: - reworked based on Baruch's run-time TLV EEPROM detection series v3 changes: - rebased on mvebu merged run-time TLV EEPROM detection series