Re: [PATCH v3 1/1] blk: Rename if_type to uclass_id

2022-09-19 Thread AKASHI Takahiro
On Sat, Sep 17, 2022 at 11:27:09AM -0600, Simon Glass wrote: > Hi Takahiro, > > On Sat, 17 Sept 2022 at 04:52, AKASHI Takahiro > wrote: > > > > On Sat, Sep 17, 2022 at 02:25:50AM -0600, Simon Glass wrote: > > > Use the word 'uclass' instead of 'if_type' to complete the conversion. > > > > NAK. >

Re: [PATCH v3 1/1] blk: Rename if_type to uclass_id

2022-09-17 Thread Simon Glass
Hi Takahiro, On Sat, 17 Sept 2022 at 04:52, AKASHI Takahiro wrote: > > On Sat, Sep 17, 2022 at 02:25:50AM -0600, Simon Glass wrote: > > Use the word 'uclass' instead of 'if_type' to complete the conversion. > > NAK. > You seem to have missed out some of my comments. > See: >

Re: [PATCH v3 1/1] blk: Rename if_type to uclass_id

2022-09-17 Thread AKASHI Takahiro
On Sat, Sep 17, 2022 at 02:25:50AM -0600, Simon Glass wrote: > Use the word 'uclass' instead of 'if_type' to complete the conversion. NAK. You seem to have missed out some of my comments. See: https://lists.denx.de/pipermail/u-boot/2022-September/494583.html (against efi_api.h, efi_device_path.c,

[PATCH v3 1/1] blk: Rename if_type to uclass_id

2022-09-17 Thread Simon Glass
Use the word 'uclass' instead of 'if_type' to complete the conversion. Signed-off-by: Simon Glass --- Changes in v3: - Drop previously applied patches - Rebase on -next after EFI changes Changes in v2: - Use conv_uclass_id() instead of the confusing uclass_id_to_uclass_id()