Re: [PATCH v3 1/2] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled

2021-05-12 Thread Masahisa Kojima
Hi Heinrich, I'm about to send v4 patch series. > 1) keep if (!IS_ENABLED(CONFIG_EFI_SECURE_BOOT)) condition I chose this option, but I reverted #ifdef statement instead of using "if (IS_ENABLED)" because I think it is better not to rely on compiler optimization. > 2) remove if

Re: [PATCH v3 1/2] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled

2021-05-10 Thread Masahisa Kojima
On Mon, 10 May 2021 at 11:07, Takahiro Akashi wrote: > > On Mon, May 10, 2021 at 09:49:03AM +0900, Masahisa Kojima wrote: > > Hi Heinrich, > > > > Sorry for the late reply. > > > > On Sat, 8 May 2021 at 23:08, Heinrich Schuchardt wrote: > > > > > > On 4/28/21 3:16 PM, Heinrich Schuchardt wrote:

Re: [PATCH v3 1/2] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled

2021-05-09 Thread Takahiro Akashi
On Mon, May 10, 2021 at 09:49:03AM +0900, Masahisa Kojima wrote: > Hi Heinrich, > > Sorry for the late reply. > > On Sat, 8 May 2021 at 23:08, Heinrich Schuchardt wrote: > > > > On 4/28/21 3:16 PM, Heinrich Schuchardt wrote: > > > On 28.04.21 14:19, Masahisa Kojima wrote: > > > > >> /** > >

Re: [PATCH v3 1/2] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled

2021-05-09 Thread Masahisa Kojima
Hi Heinrich, Sorry for the late reply. On Sat, 8 May 2021 at 23:08, Heinrich Schuchardt wrote: > > On 4/28/21 3:16 PM, Heinrich Schuchardt wrote: > > On 28.04.21 14:19, Masahisa Kojima wrote: > > >> /** > >>* cmp_pe_section() - compare virtual addresses of two PE image sections > >>*

Re: [PATCH v3 1/2] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled

2021-05-08 Thread Heinrich Schuchardt
On 4/28/21 3:16 PM, Heinrich Schuchardt wrote: On 28.04.21 14:19, Masahisa Kojima wrote: /** * cmp_pe_section() - compare virtual addresses of two PE image sections * @arg1: pointer to pointer to first section header @@ -504,6 +565,9 @@ static bool efi_image_authenticate(void

Re: [PATCH v3 1/2] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled

2021-04-28 Thread Heinrich Schuchardt
On 28.04.21 14:19, Masahisa Kojima wrote: > This is preparation for PE/COFF measurement support. > PE/COFF image hash calculation is same in both > UEFI Secure Boot image verification and measurement in > measured boot. PE/COFF image parsing functions are > gathered into efi_image_loader.c, and

[PATCH v3 1/2] efi_loader: expose efi_image_parse() even if UEFI Secure Boot is disabled

2021-04-28 Thread Masahisa Kojima
This is preparation for PE/COFF measurement support. PE/COFF image hash calculation is same in both UEFI Secure Boot image verification and measurement in measured boot. PE/COFF image parsing functions are gathered into efi_image_loader.c, and exposed even if UEFI Secure Boot is not enabled. This