Re: [PATCH v3 1/2] x86: fsp: Depend on DM_RTC

2022-11-20 Thread Bin Meng
Hi Sean, On Fri, Nov 18, 2022 at 5:16 AM Sean Anderson wrote: > > On 10/26/22 12:01, Sean Anderson wrote: > > On 10/26/22 11:58, Sean Anderson wrote: > >> On 10/25/22 20:52, Bin Meng wrote: > >>> Hi Sean, > >>> > >>> On Wed, Oct 26, 2022 at 7:35 AM Simon Glass wrote: > > Hi, > >

Re: [PATCH v3 1/2] x86: fsp: Depend on DM_RTC

2022-11-17 Thread Sean Anderson
On 10/26/22 12:01, Sean Anderson wrote: > On 10/26/22 11:58, Sean Anderson wrote: >> On 10/25/22 20:52, Bin Meng wrote: >>> Hi Sean, >>> >>> On Wed, Oct 26, 2022 at 7:35 AM Simon Glass wrote: Hi, On Mon, 24 Oct 2022 at 22:57, Stefan Roese wrote: > > On 24.10.22

Re: [PATCH v3 1/2] x86: fsp: Depend on DM_RTC

2022-10-26 Thread Sean Anderson
On 10/26/22 11:58, Sean Anderson wrote: > On 10/25/22 20:52, Bin Meng wrote: >> Hi Sean, >> >> On Wed, Oct 26, 2022 at 7:35 AM Simon Glass wrote: >>> >>> Hi, >>> >>> On Mon, 24 Oct 2022 at 22:57, Stefan Roese wrote: >>> > >>> > On 24.10.22 18:49, Bin Meng wrote: >>> > > On Mon, Oct 24, 2022 at

Re: [PATCH v3 1/2] x86: fsp: Depend on DM_RTC

2022-10-26 Thread Sean Anderson
On 10/25/22 20:52, Bin Meng wrote: > Hi Sean, > > On Wed, Oct 26, 2022 at 7:35 AM Simon Glass wrote: >> >> Hi, >> >> On Mon, 24 Oct 2022 at 22:57, Stefan Roese wrote: >> > >> > On 24.10.22 18:49, Bin Meng wrote: >> > > On Mon, Oct 24, 2022 at 11:42 PM Sean Anderson >> > > wrote: >> > >> >> >

Re: [PATCH v3 1/2] x86: fsp: Depend on DM_RTC

2022-10-25 Thread Bin Meng
Hi Sean, On Wed, Oct 26, 2022 at 7:35 AM Simon Glass wrote: > > Hi, > > On Mon, 24 Oct 2022 at 22:57, Stefan Roese wrote: > > > > On 24.10.22 18:49, Bin Meng wrote: > > > On Mon, Oct 24, 2022 at 11:42 PM Sean Anderson > > > wrote: > > >> > > >> FSP support requires DM_RTC for rtc_write32.

Re: [PATCH v3 1/2] x86: fsp: Depend on DM_RTC

2022-10-25 Thread Simon Glass
Hi, On Mon, 24 Oct 2022 at 22:57, Stefan Roese wrote: > > On 24.10.22 18:49, Bin Meng wrote: > > On Mon, Oct 24, 2022 at 11:42 PM Sean Anderson > > wrote: > >> > >> FSP support requires DM_RTC for rtc_write32. Select it. > >> > >> Fixes: ba65808e7d0 ("x86: fsp: Save stack address to CMOS for

Re: [PATCH v3 1/2] x86: fsp: Depend on DM_RTC

2022-10-24 Thread Stefan Roese
On 24.10.22 18:49, Bin Meng wrote: On Mon, Oct 24, 2022 at 11:42 PM Sean Anderson wrote: FSP support requires DM_RTC for rtc_write32. Select it. Fixes: ba65808e7d0 ("x86: fsp: Save stack address to CMOS for next S3 boot") Signed-off-by: Sean Anderson --- This seems like it would never have

Re: [PATCH v3 1/2] x86: fsp: Depend on DM_RTC

2022-10-24 Thread Sean Anderson
On 10/24/22 12:49, Bin Meng wrote: > On Mon, Oct 24, 2022 at 11:42 PM Sean Anderson wrote: >> >> FSP support requires DM_RTC for rtc_write32. Select it. >> >> Fixes: ba65808e7d0 ("x86: fsp: Save stack address to CMOS for next S3 boot") >> Signed-off-by: Sean Anderson >> --- >> This seems like it

Re: [PATCH v3 1/2] x86: fsp: Depend on DM_RTC

2022-10-24 Thread Bin Meng
On Mon, Oct 24, 2022 at 11:42 PM Sean Anderson wrote: > > FSP support requires DM_RTC for rtc_write32. Select it. > > Fixes: ba65808e7d0 ("x86: fsp: Save stack address to CMOS for next S3 boot") > Signed-off-by: Sean Anderson > --- > This seems like it would never have worked. Does

[PATCH v3 1/2] x86: fsp: Depend on DM_RTC

2022-10-24 Thread Sean Anderson
FSP support requires DM_RTC for rtc_write32. Select it. Fixes: ba65808e7d0 ("x86: fsp: Save stack address to CMOS for next S3 boot") Signed-off-by: Sean Anderson --- This seems like it would never have worked. Does fsp_save_s3_stack even get called in SPL? Maybe it should be converted to use