Re: [PATCH v3 39/57] tpm: cr50: Add ACPI support

2020-09-22 Thread Andy Shevchenko
On Mon, Sep 21, 2020 at 2:51 PM Andy Shevchenko wrote: > > On Sun, Sep 06, 2020 at 03:43:47PM -0600, Simon Glass wrote: > > Generate ACPI information for this device so that Linux can use it > > correctly. > > > + ret = acpi_device_write_interrupt_or_gpio(ctx, (struct udevice *)dev, > > +

Re: [PATCH v3 39/57] tpm: cr50: Add ACPI support

2020-09-22 Thread Bin Meng
Hi Simon, On Mon, Sep 21, 2020 at 7:51 PM Andy Shevchenko wrote: > > On Sun, Sep 06, 2020 at 03:43:47PM -0600, Simon Glass wrote: > > Generate ACPI information for this device so that Linux can use it > > correctly. > > > + ret = acpi_device_write_interrupt_or_gpio(ctx, (struct udevice

Re: [PATCH v3 39/57] tpm: cr50: Add ACPI support

2020-09-21 Thread Andy Shevchenko
On Mon, Sep 21, 2020 at 02:50:56PM +0300, Andy Shevchenko wrote: > On Sun, Sep 06, 2020 at 03:43:47PM -0600, Simon Glass wrote: > > Generate ACPI information for this device so that Linux can use it > > correctly. > > > + ret = acpi_device_write_interrupt_or_gpio(ctx, (struct udevice *)dev, > >

Re: [PATCH v3 39/57] tpm: cr50: Add ACPI support

2020-09-21 Thread Andy Shevchenko
On Sun, Sep 06, 2020 at 03:43:47PM -0600, Simon Glass wrote: > Generate ACPI information for this device so that Linux can use it > correctly. > + ret = acpi_device_write_interrupt_or_gpio(ctx, (struct udevice *)dev, > + "ready-gpios"); > + if

[PATCH v3 39/57] tpm: cr50: Add ACPI support

2020-09-06 Thread Simon Glass
Generate ACPI information for this device so that Linux can use it correctly. Signed-off-by: Simon Glass --- (no changes since v1) Changes in v1: - Capitalise ACPI_OPS_PTR - Update for acpi_device_write_i2c_dev() return-value change - Use acpi,ddn instead of acpi,desc drivers/tpm/cr50_i2c.c