Re: [PATCH v3 9/9] video console: add 12x22 console simple font test

2023-02-23 Thread Dzmitry Sankouski
Hi Simon, I investigated the usage of vidconsole_get_font_size, and it turned out, it's only used for tests, and in the `font size` command to provide font name. So I moved vidconsole_get_font_size from the public API to cmd/test.h. I think it'll be better than cluttering public API and driver

Re: [PATCH v3 9/9] video console: add 12x22 console simple font test

2023-02-17 Thread Simon Glass
Hi Dzmitry, On Fri, 17 Feb 2023 at 07:13, Dzmitry Sankouski wrote: > > How does CONSOLE_TRUETYPE interfere with CONFIG_VIDEO_FONT_SUN12X22? > I don't mean that. I tried resyncing the sandbox defconfig, and found that the defconfig additions in this patch went away, meaning they are not used.

Re: [PATCH v3 9/9] video console: add 12x22 console simple font test

2023-02-17 Thread Dzmitry Sankouski
How does CONSOLE_TRUETYPE interfere with CONFIG_VIDEO_FONT_SUN12X22? I've got all video tests passed: make sandbox_defconfig && make -j4 && ./u-boot -T -c 'ut dm' (...) Test: dm_test_video_ansi: video.c Test: dm_test_video_base: video.c Test: dm_test_video_base: video.c (flat tree) Test:

Re: [PATCH v3 9/9] video console: add 12x22 console simple font test

2023-02-15 Thread Simon Glass
Hi Dzmitry, On Wed, 15 Feb 2023 at 04:43, Dzmitry Sankouski wrote: > > Tests fonts wider than a byte. > > Signed-off-by: Dzmitry Sankouski > Reviewed-by: Simon Glass I found a problem with this > --- > Changes for v2: N/A > Changes for v2: none > > configs/sandbox_defconfig | 3 +++ >

[PATCH v3 9/9] video console: add 12x22 console simple font test

2023-02-15 Thread Dzmitry Sankouski
Tests fonts wider than a byte. Signed-off-by: Dzmitry Sankouski Reviewed-by: Simon Glass --- Changes for v2: N/A Changes for v2: none configs/sandbox_defconfig | 3 +++ test/dm/video.c | 41 +++ 2 files changed, 44 insertions(+) diff --git