On Wed, Jun 3, 2020 at 5:55 AM Ravik Hasija rahasij@.microsoft
wrote:
>
> Ramon Fried-4 wrote
> > + if (strcmp((char *)pkt + i, "windowsize") == 0) {
> > For servers that doesnt support windowsize option the above check could
> > result in accessing memory outside of valid
and incorrectly generate ACK, and the connection will eventually
> > be terminated once the retry is exhausted. Please modulo the increment
> > with TFTP_SEQUENCE_SIZE.
True, will fix.
Thanks.
> > --
> > 2.26.2
>
> Quoted from:
> http://u-boot.10912.n7.nabble.com/PATCH-v4-net-tftp-Add-client-support-for-RFC-7440-tp412754.html
>
>
>
>
> --
> Sent from: http://u-boot.10912.n7.nabble.com/
s exhausted. Please modulo the increment
> with TFTP_SEQUENCE_SIZE.
> --
> 2.26.2
Quoted from:
http://u-boot.10912.n7.nabble.com/PATCH-v4-net-tftp-Add-client-support-for-RFC-7440-tp412754.html
--
Sent from: http://u-boot.10912.n7.nabble.com/
On Sat, May 23, 2020 at 8:40 PM Matthias Brugger wrote:
...
>
> I think it makes more sense to check:
> if (tftp_window_size_option > 1 && tftp_state == STATE_SEND_RRQ)
>
> Because I understand that the tftp_state will change while the
> tftp_window_size_option is set or at compile time or
On 19/05/2020 21:25, Ramon Fried wrote:
> Add support for RFC 7440: "TFTP Windowsize Option".
>
> This optional feature allows the client and server
> to negotiate a window size of consecutive blocks to send as an
> alternative for replacing the single-block lockstep schema.
>
> windowsize
Thanks.
On Fri, May 22, 2020 at 3:29 AM rahasij wrote:
>
> Ramon Fried-4 wrote
> > + if (strcmp((char *)pkt + i, "windowsize") == 0) {
> > + tftp_windowsize =
> > + simple_strtoul((char *)pkt + i + 11,
> > +
Ramon Fried-4 wrote
> + if (strcmp((char *)pkt + i, "windowsize") == 0) {
> + tftp_windowsize =
> + simple_strtoul((char *)pkt + i + 11,
> +NULL, 10);
> +
Add support for RFC 7440: "TFTP Windowsize Option".
This optional feature allows the client and server
to negotiate a window size of consecutive blocks to send as an
alternative for replacing the single-block lockstep schema.
windowsize can be defined statically during compilation by
setting
8 matches
Mail list logo
