Re: [PATCH v5 006/101] net: Move the checksum functions to lib/

2019-12-04 Thread Bin Meng
Hi Simon, On Thu, Dec 5, 2019 at 12:28 PM Simon Glass wrote: > > Hi Bin, > > On Mon, 25 Nov 2019 at 08:11, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Nov 25, 2019 at 12:11 PM Simon Glass wrote: > > > > > > These functions are used by code outside the network support, so move them > > >

Re: [PATCH v5 006/101] net: Move the checksum functions to lib/

2019-12-04 Thread Simon Glass
Hi Bin, On Mon, 25 Nov 2019 at 08:11, Bin Meng wrote: > > Hi Simon, > > On Mon, Nov 25, 2019 at 12:11 PM Simon Glass wrote: > > > > These functions are used by code outside the network support, so move them > > to lib/ to be more accessible. > > > > Without this, the functions are only

Re: [U-Boot] [PATCH v5 006/101] net: Move the checksum functions to lib/

2019-12-02 Thread Joseph Hershberger
> -Original Message- > From: Simon Glass > Sent: Sunday, November 24, 2019 10:09 PM > To: U-Boot Mailing List > Cc: Bin Meng ; Simon Glass ; > Joseph Hershberger > Subject: [EXTERNAL] [PATCH v5 006/101] net: Move the checksum functions > to lib/ > > Th

Re: [U-Boot] [PATCH v5 006/101] net: Move the checksum functions to lib/

2019-11-25 Thread Bin Meng
Hi Simon, On Mon, Nov 25, 2019 at 12:11 PM Simon Glass wrote: > > These functions are used by code outside the network support, so move them > to lib/ to be more accessible. > > Without this, the functions are only accessible if CONFIG_NET is defined. I still don't understand this.

[U-Boot] [PATCH v5 006/101] net: Move the checksum functions to lib/

2019-11-24 Thread Simon Glass
These functions are used by code outside the network support, so move them to lib/ to be more accessible. Without this, the functions are only accessible if CONFIG_NET is defined. Many boards do not enable that option but still want to do checksums in this format. Fix up a few code-style nits