Re: [PATCH v5 1/3] x86: qemu: move QFW to its own uclass

2021-03-06 Thread Asherah Connor
Hi Bin, Simon, On 21/03/05 10:03:p, Bin Meng wrote: > On Fri, Mar 5, 2021 at 10:31 PM Simon Glass wrote: > > If I previously reviewed it you can add my tag. I wasn't sure of the correct etiquette when a large rearrangement of the patches had been done; I'll keep this in mind. > > I think

Re: [PATCH v5 1/3] x86: qemu: move QFW to its own uclass

2021-03-05 Thread Bin Meng
Hi Asherah, On Fri, Mar 5, 2021 at 10:31 PM Simon Glass wrote: > > Hi Asherah, > > On Thu, 4 Mar 2021 at 21:16, Asherah Connor wrote: > > > > Hi Simon, > > > > On 21/03/04 11:03:p, Simon Glass wrote: > > > This looks sensible but it really is a huge patch. Can it be split up a > > > bit? > > >

Re: [PATCH v5 1/3] x86: qemu: move QFW to its own uclass

2021-03-05 Thread Simon Glass
Hi Asherah, On Thu, 4 Mar 2021 at 21:16, Asherah Connor wrote: > > Hi Simon, > > On 21/03/04 11:03:p, Simon Glass wrote: > > This looks sensible but it really is a huge patch. Can it be split up a bit? > > This is a rejig of v4 previously Reviewed-by: you, see >

Re: [PATCH v5 1/3] x86: qemu: move QFW to its own uclass

2021-03-04 Thread Asherah Connor
Hi Simon, On 21/03/04 11:03:p, Simon Glass wrote: > This looks sensible but it really is a huge patch. Can it be split up a bit? This is a rejig of v4 previously Reviewed-by: you, see https://patchwork.ozlabs.org/project/uboot/list/?series=230778=%2a. Bin Meng suggested the patch be reworked

Re: [PATCH v5 1/3] x86: qemu: move QFW to its own uclass

2021-03-04 Thread Simon Glass
Hi Asherah, On Mon, 1 Mar 2021 at 01:35, Asherah Connor wrote: > > We move qfw into its own uclass and split the PIO functions into a > specific driver for that uclass. The PIO driver is selected in the > qemu-x86 board config (this covers x86 and x86_64). > > A sandbox driver and test are

[PATCH v5 1/3] x86: qemu: move QFW to its own uclass

2021-02-28 Thread Asherah Connor
We move qfw into its own uclass and split the PIO functions into a specific driver for that uclass. The PIO driver is selected in the qemu-x86 board config (this covers x86 and x86_64). A sandbox driver and test are added for the uclass, and a test in QEMU added for qfw functionality to confirm