Re: [PATCH v6 081/102] x86: Add a generic Intel GPIO driver

2020-01-29 Thread Simon Glass
Hi Wolfgang, On Fri, 13 Dec 2019 at 01:49, Wolfgang Wallner wrote: > > Hi Simon, Bin, > > > +static int intel_gpio_direction_output(struct udevice *dev, uint offset, > > +int value) > > +{ > > + struct udevice *pinctrl = dev_get_parent(dev); > > + uint

Re: [PATCH v6 081/102] x86: Add a generic Intel GPIO driver

2019-12-14 Thread Wolfgang Wallner
Hi Simon, Bin, > +static int intel_gpio_direction_output(struct udevice *dev, uint offset, > +int value) > +{ > + struct udevice *pinctrl = dev_get_parent(dev); > + uint config_offset = intel_pinctrl_get_config_reg_addr(pinctrl, offset); > + > + pcr_

Re: [PATCH v6 081/102] x86: Add a generic Intel GPIO driver

2019-12-08 Thread Bin Meng
On Sun, Dec 8, 2019 at 4:01 PM Bin Meng wrote: > > On Sat, Dec 7, 2019 at 12:54 PM Simon Glass wrote: > > > > Add a GPIO driver which uses the pinctrl driver to access the pad > > information. This driver relies on the GPIO nodes being subnodes to the > > pinctrl device. > > > > Signed-off-by: Si

Re: [PATCH v6 081/102] x86: Add a generic Intel GPIO driver

2019-12-08 Thread Bin Meng
On Sat, Dec 7, 2019 at 12:54 PM Simon Glass wrote: > > Add a GPIO driver which uses the pinctrl driver to access the pad > information. This driver relies on the GPIO nodes being subnodes to the > pinctrl device. > > Signed-off-by: Simon Glass > --- > > Changes in v6: > - Fix 'hone' typo > - Remo

[PATCH v6 081/102] x86: Add a generic Intel GPIO driver

2019-12-06 Thread Simon Glass
Add a GPIO driver which uses the pinctrl driver to access the pad information. This driver relies on the GPIO nodes being subnodes to the pinctrl device. Signed-off-by: Simon Glass --- Changes in v6: - Fix 'hone' typo - Remove the * in the first line of the binding file - Use 'north' as the node