Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-15 Thread Simon Glass
Hi, On Thu, 14 Jul 2022 at 11:55, Rob Herring wrote: > > On Wed, Jul 13, 2022 at 9:28 AM Simon Glass wrote: > > > > Hi Rob, > > > > On Tue, 12 Jul 2022 at 08:11, Rob Herring wrote: > > > > > > On Tue, Jul 12, 2022 at 5:04 AM Simon Glass wrote: > > > > > > > > Hi Ilias, > > > > > > > > On Fri,

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-14 Thread Rob Herring
On Wed, Jul 13, 2022 at 9:28 AM Simon Glass wrote: > > Hi Rob, > > On Tue, 12 Jul 2022 at 08:11, Rob Herring wrote: > > > > On Tue, Jul 12, 2022 at 5:04 AM Simon Glass wrote: > > > > > > Hi Ilias, > > > > > > On Fri, 8 Jul 2022 at 02:24, Ilias Apalodimas > > > wrote: > > > > > > > > Hi Simon,

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-14 Thread Tom Rini
On Thu, Jul 14, 2022 at 06:47:28PM +0300, Ilias Apalodimas wrote: > Hi Simon, > > [...] > > > > > > > > > > The driver needs a compatible string so it can be in the > > > > > > > > > > device tree. > > > > > > > > > > > > > > > > > > Why? I've tried to hint this on the previous iteration of >

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-14 Thread Ilias Apalodimas
Hi Simon, [...] > > > > > > > > > The driver needs a compatible string so it can be in the > > > > > > > > > device tree. > > > > > > > > > > > > > > > > Why? I've tried to hint this on the previous iteration of the > > > > > > > > patch. > > > > > > > > The RNG here is not a *device*. The

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-14 Thread Simon Glass
Hi Tom, On Thu, 14 Jul 2022 at 05:19, Tom Rini wrote: > > On Thu, Jul 14, 2022 at 04:21:58AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 13 Jul 2022 at 12:09, Tom Rini wrote: > > > > > > On Wed, Jul 13, 2022 at 09:28:16AM -0600, Simon Glass wrote: > > > > Hi Rob, > > > > > > > > On

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-14 Thread Tom Rini
On Thu, Jul 14, 2022 at 04:21:58AM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 13 Jul 2022 at 12:09, Tom Rini wrote: > > > > On Wed, Jul 13, 2022 at 09:28:16AM -0600, Simon Glass wrote: > > > Hi Rob, > > > > > > On Tue, 12 Jul 2022 at 08:11, Rob Herring wrote: > > > > > > > > On Tue, Jul

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-14 Thread Simon Glass
Hi Tom, On Wed, 13 Jul 2022 at 12:09, Tom Rini wrote: > > On Wed, Jul 13, 2022 at 09:28:16AM -0600, Simon Glass wrote: > > Hi Rob, > > > > On Tue, 12 Jul 2022 at 08:11, Rob Herring wrote: > > > > > > On Tue, Jul 12, 2022 at 5:04 AM Simon Glass wrote: > > > > > > > > Hi Ilias, > > > > > > > >

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-13 Thread Tom Rini
On Wed, Jul 13, 2022 at 09:28:16AM -0600, Simon Glass wrote: > Hi Rob, > > On Tue, 12 Jul 2022 at 08:11, Rob Herring wrote: > > > > On Tue, Jul 12, 2022 at 5:04 AM Simon Glass wrote: > > > > > > Hi Ilias, > > > > > > On Fri, 8 Jul 2022 at 02:24, Ilias Apalodimas > > > wrote: > > > > > > > > Hi

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-13 Thread Simon Glass
Hi Rob, On Tue, 12 Jul 2022 at 08:11, Rob Herring wrote: > > On Tue, Jul 12, 2022 at 5:04 AM Simon Glass wrote: > > > > Hi Ilias, > > > > On Fri, 8 Jul 2022 at 02:24, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > [...] > > > > > > > > + > > > > > UCLASS_DRIVER(tpm) = { > > > >

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-12 Thread Rob Herring
On Tue, Jul 12, 2022 at 5:04 AM Simon Glass wrote: > > Hi Ilias, > > On Fri, 8 Jul 2022 at 02:24, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > [...] > > > > > > + > > > > UCLASS_DRIVER(tpm) = { > > > > - .id = UCLASS_TPM, > > > > - .name = "tpm", > > > >

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-12 Thread Simon Glass
Hi Ilias, On Fri, 8 Jul 2022 at 02:24, Ilias Apalodimas wrote: > > Hi Simon, > > [...] > > > > + > > > UCLASS_DRIVER(tpm) = { > > > - .id = UCLASS_TPM, > > > - .name = "tpm", > > > - .flags = DM_UC_FLAG_SEQ_ALIAS, > > > + .id

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-08 Thread Ilias Apalodimas
Hi Simon, [...] > > + > > UCLASS_DRIVER(tpm) = { > > - .id = UCLASS_TPM, > > - .name = "tpm", > > - .flags = DM_UC_FLAG_SEQ_ALIAS, > > + .id = UCLASS_TPM, > > + .name = "tpm", > > + .flags

Re: [PATCH v6 3/7] tpm: Add the RNG child device

2022-07-05 Thread Simon Glass
Hi Sughosh, On Mon, 4 Jul 2022 at 07:35, Sughosh Ganu wrote: > > The TPM device comes with the random number generator(RNG) > functionality which is built into the TPM device. Add logic to add the > RNG child device in the TPM uclass post probe callback. > > The RNG device can then be used to

[PATCH v6 3/7] tpm: Add the RNG child device

2022-07-04 Thread Sughosh Ganu
The TPM device comes with the random number generator(RNG) functionality which is built into the TPM device. Add logic to add the RNG child device in the TPM uclass post probe callback. The RNG device can then be used to pass a set of random bytes to the linux kernel, need for address space