Re: [RESEND PATCH v2] rockchip: include: asm: fix entering download mode rk3066

2023-10-27 Thread Tom Rini
[Resending this as I don't see it on the archives] On Fri, Oct 27, 2023 at 11:47:25AM +0200, Johan Jonker wrote: > Hi Tom, Simon, > > The test for my patch ends with an error that is reported on various > locations on the internet. > My knowledge is limited here. Could you have a look? > > Tha

Re: [RESEND PATCH v2] rockchip: include: asm: fix entering download mode rk3066

2023-10-27 Thread Tom Rini
On Fri, Oct 27, 2023 at 11:47:25AM +0200, Johan Jonker wrote: > Hi Tom, Simon, > > The test for my patch ends with an error that is reported on various > locations on the internet. > My knowledge is limited here. Could you have a look? > > Thanks, > > Johan > > > > rockchip: include: as

Re: [RESEND PATCH v2] rockchip: include: asm: fix entering download mode rk3066

2023-10-27 Thread Johan Jonker
Hi Tom, Simon, The test for my patch ends with an error that is reported on various locations on the internet. My knowledge is limited here. Could you have a look? Thanks, Johan rockchip: include: asm: fix entering download mode rk3066 https://source.denx.de/u-boot/custodians/u-boot-roc

Re: [RESEND PATCH v2] rockchip: include: asm: fix entering download mode rk3066

2023-10-24 Thread Kever Yang
Hi Johan,     I don't have a detail build error message, but this patch do cause the 32bit ARM platforms build fail in[1]; Hi Tom,     Could you help the take a look, what's the error happen in this case? Thanks, - Kever [1] https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/jobs/7

Re: [RESEND PATCH v2] rockchip: include: asm: fix entering download mode rk3066

2023-10-13 Thread Kever Yang
On 2023/9/19 23:28, Johan Jonker wrote: Keep track of the re-entries with help of the lr register. This binary can be re-used and called from various BROM functions. Only when it's called from the part that handles SPI, NAND or EMMC hardware it needs to early return to BROM ones. In download mo

Re: [RESEND PATCH v2] rockchip: include: asm: fix entering download mode rk3066

2023-09-27 Thread Kever Yang
Hi Johan, On 2023/9/19 23:28, Johan Jonker wrote: Keep track of the re-entries with help of the lr register. This binary can be re-used and called from various BROM functions. Only when it's called from the part that handles SPI, NAND or EMMC hardware it needs to early return to BROM ones. In do

[RESEND PATCH v2] rockchip: include: asm: fix entering download mode rk3066

2023-09-19 Thread Johan Jonker
Keep track of the re-entries with help of the lr register. This binary can be re-used and called from various BROM functions. Only when it's called from the part that handles SPI, NAND or EMMC hardware it needs to early return to BROM ones. In download mode when it handles data on USB OTG and UART0