Re: [U-Boot] [PATCH 1/3] mmc: sdhci: increase the timeout value for data transfer

2012-09-24 Thread Mela Custodio
On Mon, Sep 24, 2012 at 2:23 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: The infinite loop that you mention does not occur in my situation. I also didn't occur the infinite loop. So i think that we can remove the timeout value in that function. Hi, I have no comment about that. In your

Re: [U-Boot] [PATCH 1/3] mmc: sdhci: increase the timeout value for data transfer

2012-09-24 Thread Jaehoon Chung
Hi, On 09/25/2012 04:57 AM, Mela Custodio wrote: On Mon, Sep 24, 2012 at 2:23 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: The infinite loop that you mention does not occur in my situation. I also didn't occur the infinite loop. So i think that we can remove the timeout value in that

Re: [U-Boot] [PATCH 1/3] mmc: sdhci: increase the timeout value for data transfer

2012-09-23 Thread Jaehoon Chung
Hi Rommel, I didn't think so..Our environment is support the CONFIG_SYS_MMC_MAX_BLK_COUNT. Did you know how get the timeout value 1000? If the timeout value 1000 is reasonable, i want to know what basis. Well, i don't think that my timeout value is reasonable. Actually i want to remove the

Re: [U-Boot] [PATCH 1/3] mmc: sdhci: increase the timeout value for data transfer

2012-09-23 Thread Rommel Custodio
Hello Jaehoon, I didn't think so..Our environment is support the CONFIG_SYS_MMC_MAX_BLK_COUNT. This is defined in mmc.c right after the include definitions. The comment says that: Set block count limit because of 16 bit register limit on some hardware So my use of this define is a bit of

Re: [U-Boot] [PATCH 1/3] mmc: sdhci: increase the timeout value for data transfer

2012-09-23 Thread Jaehoon Chung
Hi Rommel, On 09/24/2012 11:34 AM, Rommel Custodio wrote: Hello Jaehoon, I didn't think so..Our environment is support the CONFIG_SYS_MMC_MAX_BLK_COUNT. This is defined in mmc.c right after the include definitions. The comment says that: Set block count limit because of 16 bit

Re: [U-Boot] [PATCH 1/3] mmc: sdhci: increase the timeout value for data transfer

2012-09-22 Thread Rommel Custodio
Jaehoon Chung jh80.chung at samsung.com writes: Timeout value is tunable. When run read/write operation, sometime returned the timeout error. Because the timeout value is too short. Hello, I think it is better to fine tune CONFIG_SYS_MMC_MAX_BLK_COUNT. This gets assigned to mmc-b_max,

[U-Boot] [PATCH 1/3] mmc: sdhci: increase the timeout value for data transfer

2012-09-21 Thread Jaehoon Chung
Timeout value is tunable. When run read/write operation, sometime returned the timeout error. Because the timeout value is too short. So increased the enough timeout value. (This timeout value is used to prevent the infinite loop.) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com