Re: [U-Boot] [PATCH] Davinci I2C code cleanup

2009-02-22 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:52 Thu 19 Feb , k...@koi8.net wrote: Removed CHECK_NACK macro from Davinci I2C driver for code cleanup. Signed-off-by: Sergey Kubushyn k...@koi8.net --- cpu/arm926ejs/davinci/i2c.c | 62 +- 1 files changed, 45 insertions(+), 17 deletions(-) NACK

Re: [U-Boot] [PATCH] Davinci I2C code cleanup

2009-02-22 Thread Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090222124436.ga9...@game.jcrosoft.org you wrote: On 13:52 Thu 19 Feb , k...@koi8.net wrote: Removed CHECK_NACK macro from Davinci I2C driver for code cleanup. Signed-off-by: Sergey Kubushyn k...@koi8.net ---

Re: [U-Boot] [PATCH] Davinci I2C code cleanup

2009-02-22 Thread ksi
On Sun, 22 Feb 2009, Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090222124436.ga9...@game.jcrosoft.org you wrote: On 13:52 Thu 19 Feb , k...@koi8.net wrote: Removed CHECK_NACK macro from Davinci I2C driver for code cleanup. Signed-off-by: Sergey

Re: [U-Boot] [PATCH] Davinci I2C code cleanup

2009-02-22 Thread Wolfgang Denk
Dear k...@koi8.net, In message pine.lnx.4.64ksi.0902221346290.5...@home-gw.koi8.net you wrote: I suggest that tmp gets passed as argument to the macro. It is _NOT_ a macro working on some variable. It is simply repeating Oh yes, of course it is. It references the variable tmp, and this is

Re: [U-Boot] [PATCH] Davinci I2C code cleanup

2009-02-22 Thread ksi
On Sun, 22 Feb 2009, Wolfgang Denk wrote: Dear k...@koi8.net, In message pine.lnx.4.64ksi.0902221346290.5...@home-gw.koi8.net you wrote: I suggest that tmp gets passed as argument to the macro. It is _NOT_ a macro working on some variable. It is simply repeating Oh yes, of course

Re: [U-Boot] [PATCH] Davinci I2C code cleanup

2009-02-22 Thread Wolfgang Denk
Dear k...@koi8.net, In message pine.lnx.4.64ksi.0902221504450.5...@home-gw.koi8.net you wrote: I am sure you could come up with an efficient *and* clean solution - if you really wanted to try. There is no way you can avoid that very same code repeated several times (7 or so? didn't

Re: [U-Boot] [PATCH] Davinci I2C code cleanup

2009-02-22 Thread ksi
On Mon, 23 Feb 2009, Wolfgang Denk wrote: Dear k...@koi8.net, In message pine.lnx.4.64ksi.0902221504450.5...@home-gw.koi8.net you wrote: I am sure you could come up with an efficient *and* clean solution - if you really wanted to try. There is no way you can avoid that very same

[U-Boot] [PATCH] Davinci I2C code cleanup

2009-02-19 Thread ksi
Removed CHECK_NACK macro from Davinci I2C driver for code cleanup. Signed-off-by: Sergey Kubushyn k...@koi8.net --- cpu/arm926ejs/davinci/i2c.c | 62 +- 1 files changed, 45 insertions(+), 17 deletions(-) diff --git a/cpu/arm926ejs/davinci/i2c.c