Re: [U-Boot] [PATCH] Driver for AX88183 ethernet chip

2011-01-28 Thread Joe XUE
y are very different. It works well on my board.I have submitted it again. Best wishes. Joe > Date: Fri, 28 Jan 2011 09:02:38 +0100 > From: sba...@denx.de > To: lg...@hotmail.com > CC: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH] Driver for AX88183 ethernet chip > > On

Re: [U-Boot] [PATCH] Driver for AX88183 ethernet chip

2011-01-28 Thread Stefano Babic
On 01/27/2011 07:55 PM, root wrote: > From: Joe Xue You have to set you Signe-off-by in your patch. Please add also a commit message to explain what your patch is doing, and on which board you tested this driver. And set the net custodian as CC, this helps to get faster review. > --- a/drivers/n

Re: [U-Boot] [PATCH] Driver for AX88183 ethernet chip

2011-01-27 Thread Wolfgang Denk
Dear root, In message <1296154517-9577-1-git-send-email-lg...@hotmail.com> you wrote: > From: Joe Xue Please add your Signed-off-by: line, and provide a real name in the sender address. And then please run your patch through checkpatch.pl; as is it reports: total: 383 errors, 327 warnings Best

[U-Boot] [PATCH] Driver for AX88183 ethernet chip

2011-01-27 Thread root
From: Joe Xue --- README|7 + drivers/net/Makefile |1 + drivers/net/ax88183.c | 265 +++ drivers/net/ax88183.h | 559 + 4 files changed, 832 insertions(+), 0 deletions(-) create mode 100644 drivers/n