Re: [U-Boot] [PATCH] FIX: fat: Provide correct return code from disk_{read|write} to upper layers

2015-09-25 Thread Stephen Warren
On 09/23/2015 02:40 AM, Lukasz Majewski wrote: > Hi Stephen, > >> On 09/03/2015 08:18 AM, Lukasz Majewski wrote: >>> Hi Lukasz, >>> Hi Tom, > On Thu, Sep 03, 2015 at 02:21:39PM +0200, Lukasz Majewski wrote: > >> It is very common that FAT code is using following pattern:

Re: [U-Boot] [PATCH] FIX: fat: Provide correct return code from disk_{read|write} to upper layers

2015-09-23 Thread Stephen Warren
On 09/03/2015 08:18 AM, Lukasz Majewski wrote: > Hi Lukasz, > >> Hi Tom, >> >>> On Thu, Sep 03, 2015 at 02:21:39PM +0200, Lukasz Majewski wrote: >>> It is very common that FAT code is using following pattern: if (disk_{read|write}() < 0) return -1; Up till now the

Re: [U-Boot] [PATCH] FIX: fat: Provide correct return code from disk_{read|write} to upper layers

2015-09-23 Thread Lukasz Majewski
Hi Stephen, > On 09/03/2015 08:18 AM, Lukasz Majewski wrote: > > Hi Lukasz, > > > >> Hi Tom, > >> > >>> On Thu, Sep 03, 2015 at 02:21:39PM +0200, Lukasz Majewski wrote: > >>> > It is very common that FAT code is using following pattern: > if (disk_{read|write}() < 0) >

Re: [U-Boot] [PATCH] FIX: fat: Provide correct return code from disk_{read|write} to upper layers

2015-09-17 Thread Lukasz Majewski
Hi Tom,, > Hi, > > > It is very common that FAT code is using following pattern: > > if (disk_{read|write}() < 0) > > return -1; > > > > Up till now the above code was dead, since disk_{read|write) could > > only return value >= 0. > > As a result some errors from medium layer (i.e.

Re: [U-Boot] [PATCH] FIX: fat: Provide correct return code from disk_{read|write} to upper layers

2015-09-09 Thread Lukasz Majewski
Hi, > It is very common that FAT code is using following pattern: > if (disk_{read|write}() < 0) > return -1; > > Up till now the above code was dead, since disk_{read|write) could > only return value >= 0. > As a result some errors from medium layer (i.e. eMMC/SD) were not > caught. >

Re: [U-Boot] [PATCH] FIX: fat: Provide correct return code from disk_{read|write} to upper layers

2015-09-03 Thread Lukasz Majewski
Hi Lukasz, > Hi Tom, > > > On Thu, Sep 03, 2015 at 02:21:39PM +0200, Lukasz Majewski wrote: > > > > > It is very common that FAT code is using following pattern: > > > if (disk_{read|write}() < 0) > > > return -1; > > > > > > Up till now the above code was dead, since disk_{read|write)

Re: [U-Boot] [PATCH] FIX: fat: Provide correct return code from disk_{read|write} to upper layers

2015-09-03 Thread Lukasz Majewski
Hi Tom, > On Thu, Sep 03, 2015 at 02:21:39PM +0200, Lukasz Majewski wrote: > > > It is very common that FAT code is using following pattern: > > if (disk_{read|write}() < 0) > > return -1; > > > > Up till now the above code was dead, since disk_{read|write) could > > only return value

[U-Boot] [PATCH] FIX: fat: Provide correct return code from disk_{read|write} to upper layers

2015-09-03 Thread Lukasz Majewski
It is very common that FAT code is using following pattern: if (disk_{read|write}() < 0) return -1; Up till now the above code was dead, since disk_{read|write) could only return value >= 0. As a result some errors from medium layer (i.e. eMMC/SD) were not caught. The above behavior was

Re: [U-Boot] [PATCH] FIX: fat: Provide correct return code from disk_{read|write} to upper layers

2015-09-03 Thread Tom Rini
On Thu, Sep 03, 2015 at 02:21:39PM +0200, Lukasz Majewski wrote: > It is very common that FAT code is using following pattern: > if (disk_{read|write}() < 0) > return -1; > > Up till now the above code was dead, since disk_{read|write) could only > return value >= 0. > As a result some