Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-04-03 Thread Wolfgang Denk
Dear Ben Warren, In message 49d5338c.1050...@gmail.com you wrote: Could you please do an additional try to apply the patch produced with git-format-patch. I hope it is OK now. I tried to apply it but it didn't work, but this isn't my usual computer. I'll try on my other machine

[U-Boot] [PATCH] NetLoop initialization bug

2009-04-03 Thread Michael Zaidman
The patch fixes the bug of partial initialization of global network parameters. Upon u-boot's start up the first ping command causes a failure of the consequent TFTP command. It happens in the recently added mechanism of the NetLoop initialization where initialization of global network parameters

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-04-02 Thread Detlev Zundel
Hi Michael, Sorry for the previous mail, I have to enable the git operation via gmail on my workstation. What do you mean by this? Usually you only need a mailer which is capable to attach things inline. Even better - if you have a direct access to an mta or an smtp server, use

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-04-02 Thread Michael Zaidman
-format-patch. I hope it is OK now. Thanks, Michael From 774a3d83c4363a0bbeb0616786f522877882c88b Mon Sep 17 00:00:00 2001 From: Michael Zaidman michael.zaid...@gmail.com Date: Thu, 2 Apr 2009 18:25:03 +0300 Subject: [U-Boot] [PATCH] NetLoop initialization bug The patch fixes the bug of partial

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-04-02 Thread Ben Warren
Hi Michael, Michael Zaidman wrote: On Thu, Apr 2, 2009 at 3:47 PM, Detlev Zundel d...@denx.de wrote: I have to enable the git operation via gmail on my workstation. What do you mean by this? Usually you only need a mailer which is capable to attach things inline. Even better -

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-03-31 Thread Heiko Schocher
you are right - we do not need to clear the NetOurIP address for BOOTP, DHCP and RARP because the current implementation does not check it. So it has been removed in my new patch below. thanks. Here is the updated patch: Subject: [U-Boot] [PATCH] NetLoop initialization bug Hmm.. can you

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-03-31 Thread Detlev Zundel
Hi Michael, Please see my comments and updated patch below. As a side note, please send your patch as an inline attachment also adding your signed-off-by line. It's probably easiest to actually use git to apply your changes to a branch and use git-format-patch to create the patch. Please also

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-03-31 Thread Michael Zaidman
On Tue, Mar 31, 2009 at 12:30 PM, Detlev Zundel d...@denx.de wrote: Hi Michael, Please see my comments and updated patch below. As a side note, please send your patch as an inline attachment also adding your signed-off-by line.  It's probably easiest to actually use git to apply your

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-03-31 Thread Michael Zaidman
On Tue, Mar 31, 2009 at 12:30 PM, Detlev Zundel d...@denx.de wrote: Hi Michael, [...] The patch in your mail does still not apply.  Neither git-am (after fixing the patch with a valid e-mail) nor patch can do anything with it. Thanks  Detlev Sorry for the previous mail, I have to enable

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-03-30 Thread Heiko Schocher
-- Forwarded message -- From: Michael Zaidman michael.zaid...@gmail.com Date: Sun, Mar 22, 2009 at 8:35 PM Subject: [U-Boot] [PATCH] NetLoop initialization bug To: u-boot@lists.denx.de [U-Boot] [PATCH] NetLoop initialization bug Thanks for catching this. Your patch doesn;t apply, I

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-03-30 Thread Wolfgang Denk
Dear Heiko, In message 49d054ba.1060...@denx.de you wrote: The following 2 vars are just used, if CONFIG_CMD_CDP is used, can we do a #if defined around it? + NetOurNativeVLAN = getenv_VLAN(nvlan); + NetOurVLAN = getenv_VLAN(vlan); We probably could, but we then had to do

Re: [U-Boot] [PATCH] NetLoop initialization bug

2009-03-30 Thread Michael Zaidman
a few days ago. Could you please take a look at the proposed fix? Sorry, seems I missed it. Thanks, Michael -- Forwarded message -- From: Michael Zaidman michael.zaid...@gmail.com Date: Sun, Mar 22, 2009 at 8:35 PM Subject: [U-Boot] [PATCH] NetLoop initialization bug

[U-Boot] [PATCH] NetLoop initialization bug

2009-03-22 Thread Michael Zaidman
[U-Boot] [PATCH] NetLoop initialization bug Upon u-boot's start up the first ping command causes a failure of the consequent TFTP command. It happens in the recently added mechanism of the NetLoop initialization where initialization of global network parameters is separated in the NetInitLoop