Re: [U-Boot] [PATCH] S3C64XX: timer: replace bss variable by gd

2011-01-09 Thread Wolfgang Denk
Dear Minkyu Kang, In message 4d22d6f7.3050...@samsung.com you wrote: Use the global data instead of bss variable, replace as follow. timer_load_val - timer_rate_hz timestamp - timer_reset_value I object against using variables wich have somewhat self-explanatory names for different purposes.

Re: [U-Boot] [PATCH] S3C64XX: timer: replace bss variable by gd

2011-01-09 Thread Wolfgang Denk
Dear Reinhard Meyer, In message 4d2582f6.2040...@emk-elektronik.de you wrote: timer_load_val - timer_rate_hz timestamp - timer_reset_value I am not too happy about this misuse of gd-variables making them misnomers and the code harder to read. I'm not happy with this as well, and

Re: [U-Boot] [PATCH] S3C64XX: timer: replace bss variable by gd

2011-01-06 Thread Minkyu Kang
Dear seedshope, On 6 January 2011 00:57, seedshope bocui...@gmail.com wrote: On 01/05/2011 03:04 PM, Minkyu Kang wrote: Dear seedshope, On 4 January 2011 23:56, seedshopebocui...@gmail.com  wrote: On 01/04/2011 10:46 PM, seedshope wrote: On 01/04/2011 04:14 PM, Minkyu Kang wrote: Use

Re: [U-Boot] [PATCH] S3C64XX: timer: replace bss variable by gd

2011-01-06 Thread Reinhard Meyer
Dear concerned, Use the global data instead of bss variable, replace as follow. timer_load_val - timer_rate_hz timestamp - timer_reset_value I am not too happy about this misuse of gd-variables making them misnomers and the code harder to read. timer_rate_hz is supposed to hold the

Re: [U-Boot] [PATCH] S3C64XX: timer: replace bss variable by gd

2011-01-05 Thread seedshope
On 01/05/2011 03:04 PM, Minkyu Kang wrote: Dear seedshope, On 4 January 2011 23:56, seedshopebocui...@gmail.com wrote: On 01/04/2011 10:46 PM, seedshope wrote: On 01/04/2011 04:14 PM, Minkyu Kang wrote: Use the global data instead of bss variable, replace as follow. timer_load_val -

[U-Boot] [PATCH] S3C64XX: timer: replace bss variable by gd

2011-01-04 Thread Minkyu Kang
Use the global data instead of bss variable, replace as follow. timer_load_val - timer_rate_hz timestamp - timer_reset_value lastdec - lastinc Signed-off-by: Minkyu Kang mk7.k...@samsung.com Signed-off-by: Darius Augulis augulis.dar...@gmail.com cc: Heiko Schocher h...@denx.de ---

Re: [U-Boot] [PATCH] S3C64XX: timer: replace bss variable by gd

2011-01-04 Thread seedshope
On 01/04/2011 04:14 PM, Minkyu Kang wrote: Use the global data instead of bss variable, replace as follow. timer_load_val - timer_rate_hz timestamp - timer_reset_value lastdec - lastinc I have already test the patch on s3c6410 . It is work perfect. Thanks, seedshope Signed-off-by: Minkyu

Re: [U-Boot] [PATCH] S3C64XX: timer: replace bss variable by gd

2011-01-04 Thread seedshope
On 01/04/2011 10:46 PM, seedshope wrote: On 01/04/2011 04:14 PM, Minkyu Kang wrote: Use the global data instead of bss variable, replace as follow. timer_load_val - timer_rate_hz timestamp - timer_reset_value lastdec - lastinc I have already test the patch on s3c6410 . It is work perfect.

Re: [U-Boot] [PATCH] S3C64XX: timer: replace bss variable by gd

2011-01-04 Thread Minkyu Kang
Dear seedshope, On 4 January 2011 23:56, seedshope bocui...@gmail.com wrote: On 01/04/2011 10:46 PM, seedshope wrote: On 01/04/2011 04:14 PM, Minkyu Kang wrote: Use the global data instead of bss variable, replace as follow. timer_load_val -  timer_rate_hz timestamp -  timer_reset_value