[U-Boot] [PATCH] Support for Embedtronics/MRFSA board.

2009-08-29 Thread Sami Kantoluoto
Adds support for Embedtronics Oy's MRFSA board. Board features AT91SAM9G20 controller, 64 MB of SDRAM, two 64 Mbit data flashses (AT45DB321), SD card slot, GSM modem, GPS receiver, ZigBee (CC2420), USB host ports, USB device port, two RS232 and one RS422/RS485 port, two opto isolated inputs, two

Re: [U-Boot] [PATCH] Support for Embedtronics/MRFSA board.

2009-08-29 Thread Albin Tonnerre
Hi Sami, Please note that I'm not an u-boot custodian, so what follows is by no means authoritative. However, I do have some comments about your code: On Sat, Aug 29, 2009 at 08:22:09PM +0300, Sami Kantoluoto wrote : diff --git a/board/embedtronics/mrfsa/mrfsa.c

Re: [U-Boot] [PATCH] Support for Embedtronics/MRFSA board.

2009-08-29 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:05 Sat 29 Aug , Albin Tonnerre wrote: Hi Sami, Please note that I'm not an u-boot custodian, so what follows is by no means authoritative. However, I do have some comments about your code: agreed with all comments Best Regards, J. ___

Re: [U-Boot] [PATCH] Support for Embedtronics/MRFSA board.

2009-08-29 Thread Jean-Christophe PLAGNIOL-VILLARD
On 20:22 Sat 29 Aug , Sami Kantoluoto wrote: Adds support for Embedtronics Oy's MRFSA board. Board features AT91SAM9G20 controller, 64 MB of SDRAM, two 64 Mbit data flashses (AT45DB321), SD card slot, GSM modem, GPS receiver, ZigBee (CC2420), USB host ports, USB device port, two RS232 and

Re: [U-Boot] [PATCH] Support for Embedtronics/MRFSA board.

2009-08-29 Thread Albin Tonnerre
On Sat, Aug 29, 2009 at 08:22:09PM +0300, Sami Kantoluoto wrote : Adds support for Embedtronics Oy's MRFSA board. Board features AT91SAM9G20 controller, 64 MB of SDRAM, two 64 Mbit data flashses (AT45DB321), SD card slot, GSM modem, GPS receiver, ZigBee (CC2420), USB host ports, USB device

Re: [U-Boot] [PATCH] Support for Embedtronics/MRFSA board.

2009-08-29 Thread Sami Kantoluoto
On Sat, Aug 29, 2009 at 10:15:23PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: On 20:22 Sat 29 Aug , Sami Kantoluoto wrote: Adds support for Embedtronics Oy's MRFSA board. Board features [snip] --- Makefile | 13 + board/embedtronics/mrfsa/Makefile