Re: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

2014-09-03 Thread Fabio Estevam
On Tue, Sep 2, 2014 at 10:55 PM, Nitin Garg nitin.g...@freescale.com wrote: In the macros of HAB, like: hab_rvt_report_event_p The compiler generates bhi instead of bgt. hab_rvt_report_event_p exists prior to this patch. Is the issue present in current code then? If so, it should be handled

Re: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

2014-09-03 Thread Nitin Garg
On 09/03/2014 07:10 PM, Fabio Estevam wrote: On Tue, Sep 2, 2014 at 10:55 PM, Nitin Garg nitin.g...@freescale.com wrote: In the macros of HAB, like: hab_rvt_report_event_p The compiler generates bhi instead of bgt. hab_rvt_report_event_p exists prior to this patch. Is the issue present

Re: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

2014-09-02 Thread Nitin Garg
On 08/31/2014 08:09 PM, Otavio Salvador wrote: Hello Nitin, On Sun, Aug 31, 2014 at 5:16 PM, nitin.g...@freescale.com wrote: From: Nitin Garg nitin.g...@freescale.com Add hab_auth_img u-boot command which can be used for HAB authentication of images. Signed-off-by: Nitin Garg

Re: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

2014-09-02 Thread Otavio Salvador
Hello Nitin, On Tue, Sep 2, 2014 at 10:36 PM, Nitin Garg nitin.g...@freescale.com wrote: On 08/31/2014 08:09 PM, Otavio Salvador wrote: diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h b/arch/arm/include/asm/arch-mx6/sys_proto.h index 306d699..2bbb86e 100644 ---

Re: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

2014-09-02 Thread Nitin Garg
On 09/02/2014 08:41 PM, Otavio Salvador wrote: Hello Nitin, On Tue, Sep 2, 2014 at 10:36 PM, Nitin Garg nitin.g...@freescale.com wrote: On 08/31/2014 08:09 PM, Otavio Salvador wrote: diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h b/arch/arm/include/asm/arch-mx6/sys_proto.h index

Re: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

2014-09-02 Thread Otavio Salvador
On Tue, Sep 2, 2014 at 10:47 PM, Nitin Garg nitin.g...@freescale.com wrote: On 09/02/2014 08:41 PM, Otavio Salvador wrote: Hello Nitin, On Tue, Sep 2, 2014 at 10:36 PM, Nitin Garg nitin.g...@freescale.com wrote: On 08/31/2014 08:09 PM, Otavio Salvador wrote: diff --git

Re: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

2014-09-02 Thread Fabio Estevam
On Tue, Sep 2, 2014 at 10:47 PM, Nitin Garg nitin.g...@freescale.com wrote: But get_cpu_rev is correct, it returns unsigned int. The problem happens in hab code where there are comparisons between int and unsigned int, hence Where exactly in the hab code does the problem happen?

Re: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

2014-09-02 Thread Nitin Garg
On 09/02/2014 08:52 PM, Fabio Estevam wrote: On Tue, Sep 2, 2014 at 10:47 PM, Nitin Garg nitin.g...@freescale.com wrote: But get_cpu_rev is correct, it returns unsigned int. The problem happens in hab code where there are comparisons between int and unsigned int, hence Where exactly in

Re: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

2014-09-02 Thread Otavio Salvador
On Tue, Sep 2, 2014 at 10:55 PM, Nitin Garg nitin.g...@freescale.com wrote: On 09/02/2014 08:52 PM, Fabio Estevam wrote: On Tue, Sep 2, 2014 at 10:47 PM, Nitin Garg nitin.g...@freescale.com wrote: But get_cpu_rev is correct, it returns unsigned int. The problem happens in hab code where there

[U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

2014-08-31 Thread nitin.garg
From: Nitin Garg nitin.g...@freescale.com Add hab_auth_img u-boot command which can be used for HAB authentication of images. Signed-off-by: Nitin Garg nitin.g...@freescale.com --- arch/arm/cpu/armv7/mx6/clock.c| 40 ++- arch/arm/cpu/armv7/mx6/hab.c | 180

Re: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

2014-08-31 Thread Otavio Salvador
Hello Nitin, On Sun, Aug 31, 2014 at 5:16 PM, nitin.g...@freescale.com wrote: From: Nitin Garg nitin.g...@freescale.com Add hab_auth_img u-boot command which can be used for HAB authentication of images. Signed-off-by: Nitin Garg nitin.g...@freescale.com As the other patch I commented,

Re: [U-Boot] [PATCH] Support i.MX6 High Assurance Boot (HAB) authentication of images

2014-08-31 Thread Wolfgang Denk
Dear nitin.g...@freescale.com, In message 1409516179-32553-2-git-send-email-nitin.g...@freescale.com you wrote: + reg = readl(ccm_regs-CCGR0); + reg |= (MXC_CCM_CCGR0_CAAM_WRAPPER_IPG_MASK | + MXC_CCM_CCGR0_CAAM_WRAPPER_ACLK_MASK | +