Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Wolfgang Denk
Dear Olof Johansson, In message 20090911204750.ga22...@lixom.net you wrote: Add setup for ethernet on Tobi, allowing kernel/ramdisk to be loaded over tftp. Based on the omap3 evm code. I added a new highlevel define for Tobi to avoid having it dependent on CMD_NET (which would seem backward

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Wolfgang Denk
Dear Paulraj, Sandeep, In message 0554bef07d437848af01b9c9b5f0bc5d92708...@dlee01.ent.ti.com you wrote: Olof Johansson wrote: Add setup for ethernet on Tobi, allowing kernel/ramdisk to be loaded over tftp. Based on the omap3 evm code. I added a new highlevel define for Tobi to

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Wolfgang Denk
Dear Olof Johansson, In message cae3d950-824b-47dd-a9e3-d090ac081...@lixom.net you wrote: Random question on u-boot development process: I see you didn't add your signed-off on the commit. People don't do that when they check in patches to the u-boot trees? No, we don't do this if we

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Wolfgang Denk
Dear Ben Warren, In message f8328f7c0909131022t700abe65p5083bdc3c4630...@mail.gmail.com you wrote: I always use 'git am -s', which adds the SOB. My understanding is that maintainers should do this as an indication of approval and help in traceability. Please feel free to do that, but I

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Wolfgang Denk
Dear Paulraj, Sandeep, In message 0554bef07d437848af01b9c9b5f0bc5d91e07...@dlee01.ent.ti.com you wrote: I always use 'git am -s', which adds the SOB. My understanding is that maintainers should do this as an indication of approval and help in traceability. OK Thanks. Shall do so

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Olof Johansson
On Sep 22, 2009, at 2:48 PM, Wolfgang Denk wrote: Dear Olof Johansson, In message cae3d950-824b-47dd-a9e3-d090ac081...@lixom.net you wrote: Random question on u-boot development process: I see you didn't add your signed-off on the commit. People don't do that when they check in patches

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Olof Johansson
On Tue, Sep 22, 2009 at 09:41:42PM +0200, Wolfgang Denk wrote: Please use git format-patch / git send-email to create and submit patches. For example, it is always nice to see a file statistics in the patch. k. + MUX_VAL(CP(GPMC_CLK), (IDIS | PTU | EN | M0)) /*GPMC_CLK*/\ +

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Olof Johansson
On Sep 22, 2009, at 2:50 PM, Wolfgang Denk wrote: Dear Ben Warren, In message f8328f7c0909131022t700abe65p5083bdc3c4630...@mail.gmail.com you wrote: I always use 'git am -s', which adds the SOB. My understanding is that maintainers should do this as an indication of approval and

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Wolfgang Denk
Dear Olof Johansson, In message c6505381-97ac-4e05-9cca-6089f6996...@gmail.com you wrote: Please feel free to do that, but I consider this just adding line-noise, unless you _really_ express special approval. Which sense would it make if I added a s-o-b to each and every commit I'm

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Wolfgang Denk
Dear Olof Johansson, In message 3c828e04-9cb1-4ccf-ad61-904f8956f...@gmail.com you wrote: Linus does not S-o-b all patches that go into the Linux kernel, or does he? He does. No, he does not. For example, see

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Olof Johansson
On Sep 22, 2009, at 4:28 PM, Wolfgang Denk wrote: Dear Olof Johansson, In message c6505381-97ac-4e05-9cca-6089f6996...@gmail.com you wrote: Please feel free to do that, but I consider this just adding line-noise, unless you _really_ express special approval. Which sense would it make if

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Olof Johansson
On Sep 22, 2009, at 4:32 PM, Wolfgang Denk wrote: 56327c2a58b76291616f15c9c84a180cf7049645 committer Jaswinder Singh Rajput jaswinderraj...@gmail.com Sun, 20 Sep 2009 10:32:20 + (15:32 +0530) He didn't commit it. -Olof ___ U-Boot mailing

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Wolfgang Denk
Dear Olof Johansson, In message 20090922203431.ga14...@lixom.net you wrote: + MUX_VAL(CP(GPMC_CLK), (IDIS | PTU | EN | M0)) /*GPMC_CLK*/\ + MUX_VAL(CP(GPMC_WAIT2), (IEN | PTU | EN | M4)) /*GPIO_64*/\ + /* - SMSC911X_NRES*/\

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Olof Johansson
On Sep 22, 2009, at 4:34 PM, Wolfgang Denk wrote: Dear Olof Johansson, In message 20090922203431.ga14...@lixom.net you wrote: + MUX_VAL(CP(GPMC_CLK),(IDIS | PTU | EN | M0)) /*GPMC_CLK*/\ + MUX_VAL(CP(GPMC_WAIT2), (IEN | PTU | EN | M4)) /*GPIO_64*/\ +

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Wolfgang Denk
Dear Olof Johansson, In message fbc6adc7-d76b-4186-9e13-889041453...@gmail.com you wrote: I guess you don't see what the difference between applying a patch and pulling a tree is. Indeed I don't. Isn't pulling a tree the same as applying a number of patches using soem highly efficient

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Wolfgang Denk
Dear Olof Johansson, In message 00aa7a76-7fe3-440e-acbb-0d7fdcd4c...@gmail.com you wrote: On Sep 22, 2009, at 4:32 PM, Wolfgang Denk wrote: 56327c2a58b76291616f15c9c84a180cf7049645 committer Jaswinder Singh Rajput jaswinderraj...@gmail.com Sun, 20 Sep 2009 10:32:20 + (15:32

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Tom
Wolfgang Denk wrote: Dear Olof Johansson, In message cae3d950-824b-47dd-a9e3-d090ac081...@lixom.net you wrote: Random question on u-boot development process: I see you didn't add your signed-off on the commit. People don't do that when they check in patches to the u-boot trees? No,

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Wolfgang Denk
Dear Olof Johansson, In message cc2dd232-01b8-4587-ad41-e6f2d9b2c...@lixom.net you wrote: No, please submit a new version which also incorporates the cleanup patches by Dirk. I didn't see those, since I wasn't cc:d. See the ML archive, then. I will not pull the current version. So

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Olof Johansson
On Sep 22, 2009, at 4:49 PM, Wolfgang Denk wrote: Dear Olof Johansson, In message cc2dd232-01b8-4587-ad41-e6f2d9b2c...@lixom.net you wrote: No, please submit a new version which also incorporates the cleanup patches by Dirk. I didn't see those, since I wasn't cc:d. See the ML archive,

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-22 Thread Jean-Christian de Rivaz
Wolfgang Denk a écrit : Dear Olof Johansson, In message 3c828e04-9cb1-4ccf-ad61-904f8956f...@gmail.com you wrote: Linus does not S-o-b all patches that go into the Linux kernel, or does he? He does. No, he does not. Maybe not so off-tropic, Linus have talked precisely about that today:

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-13 Thread Ben Warren
On Sat, Sep 12, 2009 at 10:33 AM, Paulraj, Sandeep s-paul...@ti.com wrote: Olof Johansson wrote: Add setup for ethernet on Tobi, allowing kernel/ramdisk to be loaded over tftp. Based on the omap3 evm code. I added a new highlevel define for Tobi to avoid having it dependent

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-13 Thread Paulraj, Sandeep
I always use 'git am -s', which adds the SOB. My understanding is that maintainers should do this as an indication of approval and help in traceability. regards, Ben OK Thanks. Shall do so henceforth. Regards, Sandeep ___ U-Boot mailing

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-13 Thread Steve Sakoman
On Fri, Sep 11, 2009 at 1:47 PM, Olof Johansson o...@lixom.net wrote: Add setup for ethernet on Tobi, allowing kernel/ramdisk to be loaded over tftp. Based on the omap3 evm code. I added a new highlevel define for Tobi to avoid having it dependent on CMD_NET (which would seem backward in

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-12 Thread Paulraj, Sandeep
Olof Johansson wrote: Add setup for ethernet on Tobi, allowing kernel/ramdisk to be loaded over tftp. Based on the omap3 evm code. I added a new highlevel define for Tobi to avoid having it dependent on CMD_NET (which would seem backward in this case). Signed-off-by: Olof

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-12 Thread Paulraj, Sandeep
Olof Johansson wrote: Add setup for ethernet on Tobi, allowing kernel/ramdisk to be loaded over tftp. Based on the omap3 evm code. I added a new highlevel define for Tobi to avoid having it dependent on CMD_NET (which would seem backward in this case). Signed-off-by: Olof

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-12 Thread Olof Johansson
On Sep 12, 2009, at 10:16 AM, Paulraj, Sandeep wrote: Olof Johansson wrote: Add setup for ethernet on Tobi, allowing kernel/ramdisk to be loaded over tftp. Based on the omap3 evm code. I added a new highlevel define for Tobi to avoid having it dependent on CMD_NET (which would seem backward

[U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-11 Thread Olof Johansson
Add setup for ethernet on Tobi, allowing kernel/ramdisk to be loaded over tftp. Based on the omap3 evm code. I added a new highlevel define for Tobi to avoid having it dependent on CMD_NET (which would seem backward in this case). Signed-off-by: Olof Johansson o...@lixom.net diff --git

Re: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support

2009-09-11 Thread Dirk Behme
Olof Johansson wrote: Add setup for ethernet on Tobi, allowing kernel/ramdisk to be loaded over tftp. Based on the omap3 evm code. I added a new highlevel define for Tobi to avoid having it dependent on CMD_NET (which would seem backward in this case). Signed-off-by: Olof Johansson