Re: [U-Boot] [PATCH] common/memsize.c: restore content of the base address

Hi Wolfgang, > From: Wolfgang Denk [mailto:w...@denx.de] > Subject: Re: [U-Boot] [PATCH] common/memsize.c: restore content of the base > > Dear Patrick, > > In message <94c2391ea4e943fb9f65e7b0943c9...@sfhdag6node3.st.com> > you wrote: > > > Ok, I will do it but only in background... > > I will

Re: [U-Boot] [PATCH] common/memsize.c: restore content of the base address

Dear Patrick, In message <94c2391ea4e943fb9f65e7b0943c9...@sfhdag6node3.st.com> you wrote: > > example for physical size limited to 128MB = bit 0 to 26 mapped to the > memory, bit 27 used > access to 0x000 => physical access to 0x > acesss to 0x7FFF => physical access to 0x7F

Re: [U-Boot] [PATCH] common/memsize.c: restore content of the base address

Hi Wolfgang, > -Original Message- > From: Wolfgang Denk [mailto:w...@denx.de] > > Dear Patrick, > > In message <10532397af3d416f9a1b30f0b09a9...@sfhdag6node3.st.com> > you wrote: > > > > > You should keep the functionality, but move it to where it belongs, > > > i. e. to the SPL running

Re: [U-Boot] [PATCH] common/memsize.c: restore content of the base address

Dear Patrick, In message <10532397af3d416f9a1b30f0b09a9...@sfhdag6node3.st.com> you wrote: > > > You should keep the functionality, but move it to where it belongs, i. e. > > to the > > SPL running from OCM. > > I remove it in U-Boot and I call it only in SPL, > executed in onchip RAM, juste af

Re: [U-Boot] [PATCH] common/memsize.c: restore content of the base address

Dear Wolfgang, > From: Wolfgang Denk [mailto:w...@denx.de] > > Dear Patrick, > > In message <885aaa3abdfe440591ea271f92ab4...@sfhdag6node3.st.com> > you wrote: >> > > But it is recommended in ./doc/README.arm-relocation: > > > Where do you read that this allows runing the code from the same m

Re: [U-Boot] [PATCH] common/memsize.c: restore content of the base address

Dear Patrick, In message <885aaa3abdfe440591ea271f92ab4...@sfhdag6node3.st.com> you wrote: > > > You mean you are running this code from the very memory you are sizing? > > This > > is fundamentally broken. You must not do this! > > Yes I do it, sorry if it is a error. > > But it is recommen

Re: [U-Boot] [PATCH] common/memsize.c: restore content of the base address

> From: Wolfgang Denk [mailto:w...@denx.de] > Subject: Re: [U-Boot] [PATCH] common/memsize.c: restore content of the base > address > > Dear Patrick, > > In message <6daf1478e4284b8590c2862c6a504...@sfhdag6node3.st.com> > you wrote: > > > > After inve

Re: [U-Boot] [PATCH] common/memsize.c: restore content of the base address

Dear Patrick, In message <6daf1478e4284b8590c2862c6a504...@sfhdag6node3.st.com> you wrote: > > After investigation, I found an potential issue when the current code of > get_ram_size() > is loaded near of power of 2 offset (just before an address modified by the > code)... > In fact the conte

Re: [U-Boot] [PATCH] common/memsize.c: restore content of the base address

Dear Wolfgang, > > Dear Patrick, > > In message <1512575263-23010-1-git-send-email-patrick.delau...@st.com> > you wrote: > > In function get_ram_size() and for 2 last cases the content of the > > base address (*base) is not restored even it is correctly saved in > > stack (in save[i]). > > > >

Re: [U-Boot] [PATCH] common/memsize.c: restore content of the base address

Dear Patrick, In message <1512575263-23010-1-git-send-email-patrick.delau...@st.com> you wrote: > In function get_ram_size() and for 2 last cases the content of > the base address (*base) is not restored even it is > correctly saved in stack (in save[i]). > > This patch solved this issue. > The

[U-Boot] [PATCH] common/memsize.c: restore content of the base address

In function get_ram_size() and for 2 last cases the content of the base address (*base) is not restored even it is correctly saved in stack (in save[i]). This patch solved this issue. The content of the base address is saved in new variable in stack (save_base) to avoid the need of other informat