Re: [U-Boot] [PATCH] drivers: net: ldpaa_eth: Correct error handler for qbman_swp_acquire()

2017-11-17 Thread York Sun
On 10/26/2017 03:33 AM, Ashish Kumar wrote: > Correcting error handing for qbman_swp_acquire. The return value is zero is > an error condition since number of buffer copied is zero meaning > there are no free buffers for allocation. > > Signed-off-by: Ashish Kumar >

Re: [U-Boot] [PATCH] drivers: net: ldpaa_eth: Correct error handler for qbman_swp_acquire()

2017-10-30 Thread Ashish Kumar
Please see inline. -Original Message- From: York Sun Sent: Tuesday, October 31, 2017 12:32 AM To: Ashish Kumar ; Roy Pledge Cc: joe.hershber...@gmail.com; Prabhakar Kushwaha ; u-boot@lists.denx.de Subject: Re:

Re: [U-Boot] [PATCH] drivers: net: ldpaa_eth: Correct error handler for qbman_swp_acquire()

2017-10-30 Thread York Sun
On 10/29/2017 10:23 PM, Ashish Kumar wrote: > Hello York, > > The definition of qbman_swp_acquire(), is not owned by u-boot, it is part of > qbman drivers which is owned by Roy. > u-boot gets this definition from flib code and same is used in u-boot as it > is. > > So, moving this error

Re: [U-Boot] [PATCH] drivers: net: ldpaa_eth: Correct error handler for qbman_swp_acquire()

2017-10-29 Thread Ashish Kumar
Hello York, The definition of qbman_swp_acquire(), is not owned by u-boot, it is part of qbman drivers which is owned by Roy. u-boot gets this definition from flib code and same is used in u-boot as it is. So, moving this error handler in qbman_swp_acquire for num == 0, may result in

Re: [U-Boot] [PATCH] drivers: net: ldpaa_eth: Correct error handler for qbman_swp_acquire()

2017-10-26 Thread York Sun
On 10/26/2017 03:33 AM, Ashish Kumar wrote: > Correcting error handing for qbman_swp_acquire. The return value is zero is > an error condition since number of buffer copied is zero meaning > there are no free buffers for allocation. > > Signed-off-by: Ashish Kumar >

[U-Boot] [PATCH] drivers: net: ldpaa_eth: Correct error handler for qbman_swp_acquire()

2017-10-26 Thread Ashish Kumar
Correcting error handing for qbman_swp_acquire. The return value is zero is an error condition since number of buffer copied is zero meaning there are no free buffers for allocation. Signed-off-by: Ashish Kumar Signed-off-by: Kushwaha Prabhakar ---