Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-17 Thread Tom Rini
On Fri, Dec 14, 2012 at 06:54:05PM -0600, Scott Wood wrote: SPL doesn't use the environment. These list entries prevent the functions from being garbage-collected, even though nothing will look at the list. This caused several SPL builds (e.g. P2020RDB-PC_NAND) to break due to size

Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-17 Thread Scott Wood
On 12/17/2012 08:52:59 AM, Tom Rini wrote: On Fri, Dec 14, 2012 at 06:54:05PM -0600, Scott Wood wrote: SPL doesn't use the environment. These list entries prevent the functions from being garbage-collected, even though nothing will look at the list. This caused several SPL builds (e.g.

Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/17/12 13:53, Scott Wood wrote: On 12/17/2012 08:52:59 AM, Tom Rini wrote: On Fri, Dec 14, 2012 at 06:54:05PM -0600, Scott Wood wrote: SPL doesn't use the environment. These list entries prevent the functions from being garbage-collected,

Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-17 Thread Wolfgang Denk
Dear Tom, In message 50cf6ea8.4050...@ti.com you wrote: Since I'd assume 'sort' in make isn't sort -u, I'm not sure how it's filtering out the dupes unless we don't really need it afterall, am335x_evm builds with CONFIG_SPL_NET_SUPPORT enabled. I'm curious now, so I'm poking it. Wrong

Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/17/12 14:55, Wolfgang Denk wrote: Dear Tom, In message 50cf6ea8.4050...@ti.com you wrote: Since I'd assume 'sort' in make isn't sort -u, I'm not sure how it's filtering out the dupes unless we don't really need it afterall, am335x_evm

Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-17 Thread Joe Hershberger
Hi Tom, On Mon, Dec 17, 2012 at 1:58 PM, Tom Rini tr...@ti.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/17/12 14:55, Wolfgang Denk wrote: Dear Tom, In message 50cf6ea8.4050...@ti.com you wrote: Since I'd assume 'sort' in make isn't sort -u, I'm not sure how it's

[U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-14 Thread Scott Wood
SPL doesn't use the environment. These list entries prevent the functions from being garbage-collected, even though nothing will look at the list. This caused several SPL builds (e.g. P2020RDB-PC_NAND) to break due to size limitations. A static inline function is used to provide a context in

Re: [U-Boot] [PATCH] env: don't generate callback list entries for SPL

2012-12-14 Thread Joe Hershberger
Hi Scott, On Fri, Dec 14, 2012 at 6:54 PM, Scott Wood scottw...@freescale.com wrote: SPL doesn't use the environment. These list entries prevent the functions from being garbage-collected, even though nothing will look at the list. This caused several SPL builds (e.g. P2020RDB-PC_NAND) to