Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-05-18 Thread Jerry Van Baren
On 05/17/2013 02:05 PM, Tom Rini wrote: On Fri, May 17, 2013 at 09:59:23AM -0700, Doug Anderson wrote: Tom, On Fri, May 17, 2013 at 9:52 AM, Tom Rini tr...@ti.com wrote: Saw your reply but don't completely understand it. I think we'd still like U-Boot to populate the memory property if

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-05-17 Thread Doug Anderson
Tom, On Wed, May 15, 2013 at 9:51 AM, Doug Anderson diand...@chromium.org wrote: Vadim, On Wed, May 15, 2013 at 8:58 AM, Vadim Bendebury vben...@chromium.org wrote: This is not a big deal for u-boot (maybe very marginally inefficient when determining the actual memory size). Is this a big

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-05-17 Thread Tom Rini
On Fri, May 17, 2013 at 09:26:19AM -0700, Doug Anderson wrote: Tom, On Wed, May 15, 2013 at 9:51 AM, Doug Anderson diand...@chromium.org wrote: Vadim, On Wed, May 15, 2013 at 8:58 AM, Vadim Bendebury vben...@chromium.org wrote: This is not a big deal for u-boot (maybe very

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-05-17 Thread Doug Anderson
Tom, On Fri, May 17, 2013 at 9:40 AM, Tom Rini tr...@ti.com wrote: I think my email must have been lost in the shuffle, see http://patchwork.ozlabs.org/patch/240687/ So yes, I've got another fix in mind that should solve this and some other problems. Saw your reply but don't completely

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-05-17 Thread Tom Rini
On Fri, May 17, 2013 at 09:48:13AM -0700, Doug Anderson wrote: Tom, On Fri, May 17, 2013 at 9:40 AM, Tom Rini tr...@ti.com wrote: I think my email must have been lost in the shuffle, see http://patchwork.ozlabs.org/patch/240687/ So yes, I've got another fix in mind that should solve

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-05-17 Thread Doug Anderson
Tom, On Fri, May 17, 2013 at 9:52 AM, Tom Rini tr...@ti.com wrote: Saw your reply but don't completely understand it. I think we'd still like U-Boot to populate the memory property if possible and it sounds like your patch would prevent that. One reason is that we'd like to be able to

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-05-17 Thread Tom Rini
On Fri, May 17, 2013 at 09:59:23AM -0700, Doug Anderson wrote: Tom, On Fri, May 17, 2013 at 9:52 AM, Tom Rini tr...@ti.com wrote: Saw your reply but don't completely understand it. I think we'd still like U-Boot to populate the memory property if possible and it sounds like your patch

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-05-15 Thread Vadim Bendebury
On Tue, Apr 30, 2013 at 2:14 PM, Tom Rini tr...@ti.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/30/2013 04:49 PM, Doug Anderson wrote: Tom, On Tue, Apr 30, 2013 at 1:35 PM, Tom Rini tr...@ti.com wrote: And I guess having this knowledge correct for the kernel is useful in

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-05-15 Thread Tom Rini
On Wed, May 15, 2013 at 08:58:03AM -0700, Vadim Bendebury wrote: On Tue, Apr 30, 2013 at 2:14 PM, Tom Rini tr...@ti.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/30/2013 04:49 PM, Doug Anderson wrote: Tom, On Tue, Apr 30, 2013 at 1:35 PM, Tom Rini tr...@ti.com

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-05-15 Thread Doug Anderson
Vadim, On Wed, May 15, 2013 at 8:58 AM, Vadim Bendebury vben...@chromium.org wrote: This is not a big deal for u-boot (maybe very marginally inefficient when determining the actual memory size). Is this a big deal for kernel? I mean it is easy to squash these seven memory banks into one when

[U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-04-30 Thread Doug Anderson
It appears that there are some cases where we have more than 4 banks of memory. Use CONFIG_NR_DRAM_BANKS if it's defined to handle this. This will take up a little extra stack space (64 bytes extra if we go up to 8 banks), but that seems OK. Signed-off-by: Doug Anderson diand...@chromium.org ---

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-04-30 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/30/2013 04:22 PM, Doug Anderson wrote: It appears that there are some cases where we have more than 4 banks of memory. Use CONFIG_NR_DRAM_BANKS if it's defined to handle this. This will take up a little extra stack space (64 bytes extra

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-04-30 Thread Doug Anderson
Tom, On Tue, Apr 30, 2013 at 1:35 PM, Tom Rini tr...@ti.com wrote: And I guess having this knowledge correct for the kernel is useful in other contexts like when we want to power down some banks of memory but not others? I mean, there's lots of platforms that lie and say 1 bank since we

Re: [U-Boot] [PATCH] fdt_support: Use CONFIG_NR_DRAM_BANKS if defined

2013-04-30 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/30/2013 04:49 PM, Doug Anderson wrote: Tom, On Tue, Apr 30, 2013 at 1:35 PM, Tom Rini tr...@ti.com wrote: And I guess having this knowledge correct for the kernel is useful in other contexts like when we want to power down some banks of