Re: [U-Boot] [PATCH] ftsmc020: enhance for features and asm support.

HI Wolfgang, >> This is because writing assembly code (lowlevel_init) is really a >> necessity for setting the timing >> and power outpur correctly to these registers (SMC, SDMC, PMU). > > What exactly prevents you from writing the very same code in C? > >> It is required to give a correct setting

Re: [U-Boot] [PATCH] ftsmc020: enhance for features and asm support.

Dear Macpaul Lin, Please keep the mailing list on Cc: (re-added) In message you wrote: > > > I repeat again: I consider this manual unrolling of the nested structs > > a Bad Thing. You should have separate offsets for each of the nested > > structs. > > The above code is really a rework for

Re: [U-Boot] [PATCH] ftsmc020: enhance for features and asm support.

Dear Macpaul Lin, In message you wrote: > > There are lots of register offset is widely been used both in > lowlevel_init and C environment. Yes, there is a lot os mess that piled up over the years. It will take time to clean this up. > If there is a code wrote as writel(0x1, AT91_ASM_SMC_S

Re: [U-Boot] [PATCH] ftsmc020: enhance for features and asm support.

Hi Wolfgang 2011/3/31 Wolfgang Denk : > Dear Macpaul Lin, > > We should probably split architecture and/or board specific additions > like these into separate files in the respectice architecture / board > directories.  Eventually we add make targets for these, then; for now > it's probably suffic

Re: [U-Boot] [PATCH] ftsmc020: enhance for features and asm support.

Dear Macpaul Lin, In message you wrote: > > I'm not sure if this way I use make-asm-offset is correct. > > First I add the OFFSET marco of ftsmc020 into "lib/asm-offsets.c". > The file "lib/asm-offsets.c" becomes We should probably split architecture and/or board specific additions like these

Re: [U-Boot] [PATCH] ftsmc020: enhance for features and asm support.

Hi Wolfgang, 2011/3/25 Wolfgang Denk : > Dear macp...@andestech.com, > > There is no (known) problem with it, but you have to be careful about > the context you are running in - the script as is is supposed to be > run in "make" context, which means different $ expansion rules then > when you try

Re: [U-Boot] [PATCH] ftsmc020: enhance for features and asm support.

Dear macp...@andestech.com, In message <50fd90c65c53fb45badeebcd84ff07f202ec0...@atcpcs06.andestech.com> you wrote: > > > Neither I ran the command > > "tools/scripts/make-asm-offsets include/faraday/ftsmc020.h > include/faraday/ftsmc020-genasm.h" > nor I ran > sed -ne "/^->/{s:->#\(.*\):/* \1 *

Re: [U-Boot] [PATCH] ftsmc020: enhance for features and asm support.

Hi Wolfgnag > In message > <1300965924-20508-1-git-send-email-macp...@andestech.com> you wrote: > > 1. Enhance ftsmc020 according to datasheets. > > 2. Add assembly register offsets for support lowlevel_init.S. > > NAK. Such register offsets should be automatically generated from the > respecti

Re: [U-Boot] [PATCH] ftsmc020: enhance for features and asm support.

Dear "Macpaul Lin", In message <1300965924-20508-1-git-send-email-macp...@andestech.com> you wrote: > 1. Enhance ftsmc020 according to datasheets. > 2. Add assembly register offsets for support lowlevel_init.S. NAK. Such register offsets should be automatically generated from the respective C str

[U-Boot] [PATCH] ftsmc020: enhance for features and asm support.

1. Enhance ftsmc020 according to datasheets. 2. Add assembly register offsets for support lowlevel_init.S. Signed-off-by: Macpaul Lin --- Note: This patch should be applied after patch "[U-Boot,v2,4/4] ftsmc020: move ftsmc020 static mem controller to driver/mtd" (/patch/87862/) is applied.