Re: [U-Boot] [PATCH] hikey: Take peripherals out of reset during board init

2019-03-21 Thread Daniel Thompson
On Wed, Mar 20, 2019 at 11:56:58AM +0530, Manivannan Sadhasivam wrote: > Hi Peter, > > On Tue, Mar 19, 2019 at 11:29:01AM +, Peter Griffin wrote: > > Hi Mani, > > > > This looks like a bug in the Linux kernel. The kernel driver should be > > correctly > > handling the reset lines of the I2C

Re: [U-Boot] [PATCH] hikey: Take peripherals out of reset during board init

2019-03-20 Thread Manivannan Sadhasivam
Hi Peter, On Tue, Mar 19, 2019 at 11:29:01AM +, Peter Griffin wrote: > Hi Mani, > > This looks like a bug in the Linux kernel. The kernel driver should be > correctly > handling the reset lines of the I2C or SPI peripheral rather than replying > on > the bootloader to have already taken it

Re: [U-Boot] [PATCH] hikey: Take peripherals out of reset during board init

2019-03-19 Thread Peter Griffin
Hi Mani, This looks like a bug in the Linux kernel. The kernel driver should be correctly handling the reset lines of the I2C or SPI peripheral rather than replying on the bootloader to have already taken it out of reset. Peter. On Fri, 8 Mar 2019 at 08:57, Manivannan Sadhasivam <

[U-Boot] [PATCH] hikey: Take peripherals out of reset during board init

2019-03-08 Thread Manivannan Sadhasivam
Peripherals like I2C and SPI needs to be taken out of reset during board init for functioning properly. Hence, add `hi6220_periph_reset` function for doing the same. For instance without this function, I2C will fail like below while booting linux: [0.608033] i2c_designware f710.i2c: