Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-25 Thread Benoît Thébaudeau
On 25/01/2018 at 11:17, Michael Nazzareno Trimarchi wrote: > On Thu, Jan 25, 2018 at 11:02 AM, Benoît Thébaudeau > wrote: >> You said that setting SION only for a UART is enough to trigger your USB >> issue. >> Of course, there is no reason to set SION by default for a UART, but I was >> thinkin

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-25 Thread Michael Nazzareno Trimarchi
Hi On Thu, Jan 25, 2018 at 11:02 AM, Benoît Thébaudeau wrote: > Hi Michael, > > On 25/01/2018 at 06:47, Michael Nazzareno Trimarchi wrote: >> On 25 Jan. 2018 12:07 am, "Fabio Estevam" > > wrote: >> >> Hi Michael, >> >> On Wed, Jan 24, 2018 at 3:46 PM, Michael Na

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-25 Thread Benoît Thébaudeau
Hi Michael, On 25/01/2018 at 06:47, Michael Nazzareno Trimarchi wrote: > On 25 Jan. 2018 12:07 am, "Fabio Estevam" > wrote: > > Hi Michael, > > On Wed, Jan 24, 2018 at 3:46 PM, Michael Nazzareno Trimarchi > mailto:mich...@amarulasolutions.com>> > wrote: >

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi On 25 Jan. 2018 12:07 am, "Fabio Estevam" wrote: Hi Michael, On Wed, Jan 24, 2018 at 3:46 PM, Michael Nazzareno Trimarchi wrote: > This is exactly my initial propose. Can we give a try and manage on board level? The kernel should not rely on the IOMUX setting done by the bootloader. Do y

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Fabio Estevam
Hi Michael, On Wed, Jan 24, 2018 at 3:46 PM, Michael Nazzareno Trimarchi wrote: > This is exactly my initial propose. Can we give a try and manage on board > level? The kernel should not rely on the IOMUX setting done by the bootloader. Do you use 0x8000 in your dts IOMUX configuration by

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi On Wed, Jan 24, 2018 at 6:36 PM, Fabio Estevam wrote: > Hi Benoît, > > On Wed, Jan 24, 2018 at 3:29 PM, Benoît Thébaudeau wrote: > >> In mainline Linux, SION is also set by some DTS files (MX25_PAD_* 0x4000 >> flag) for FEC MDIO and SD CMD/CLK/DATAn. > > Which I think it is fine as it is

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Fabio Estevam
Hi Benoît, On Wed, Jan 24, 2018 at 3:29 PM, Benoît Thébaudeau wrote: > In mainline Linux, SION is also set by some DTS files (MX25_PAD_* 0x4000 > flag) for FEC MDIO and SD CMD/CLK/DATAn. Which I think it is fine as it is set on a per board basis. Maybe we could do the same in U-Boot. Than

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi On Wed, Jan 24, 2018 at 6:29 PM, Benoît Thébaudeau wrote: > Hi Fabio, > > On 24/01/2018 at 18:21, Fabio Estevam wrote: >> On Wed, Jan 24, 2018 at 3:12 PM, Michael Nazzareno Trimarchi >> wrote: >> >>> From the datasheet I have: >>> >>> Software Input On Field. Force the selected mux mode Input

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Benoît Thébaudeau
Hi Fabio, On 24/01/2018 at 18:21, Fabio Estevam wrote: > On Wed, Jan 24, 2018 at 3:12 PM, Michael Nazzareno Trimarchi > wrote: > >> From the datasheet I have: >> >> Software Input On Field. Force the selected mux mode Input path no >> matter of MUX_MODE functionality. >> 1: Force input path of p

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Fabio Estevam
Hi Michael, On Wed, Jan 24, 2018 at 3:12 PM, Michael Nazzareno Trimarchi wrote: > From the datasheet I have: > > Software Input On Field. Force the selected mux mode Input path no > matter of MUX_MODE functionality. > 1: Force input path of pad A14. > 0: Input Path is determined by functionality

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Benoît Thébaudeau
On 24/01/2018 at 18:12, Michael Nazzareno Trimarchi wrote: > On Wed, Jan 24, 2018 at 6:05 PM, Benoît Thébaudeau wrote: >> Hi Michael, >> >> On 24/01/2018 at 17:46, Michael Nazzareno Trimarchi wrote: >>> On Wed, Jan 24, 2018 at 5:38 PM, Fabio Estevam wrote: Hi Michael, [Removed usb

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi On Wed, Jan 24, 2018 at 6:05 PM, Benoît Thébaudeau wrote: > Hi Michael, > > On 24/01/2018 at 17:46, Michael Nazzareno Trimarchi wrote: >> On Wed, Jan 24, 2018 at 5:38 PM, Fabio Estevam wrote: >>> Hi Michael, >>> >>> [Removed usb list as this is off-topic for them] >>> >>> On Wed, Jan 24, 2018

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Benoît Thébaudeau
Hi Michael, On 24/01/2018 at 17:46, Michael Nazzareno Trimarchi wrote: > On Wed, Jan 24, 2018 at 5:38 PM, Fabio Estevam wrote: >> Hi Michael, >> >> [Removed usb list as this is off-topic for them] >> >> On Wed, Jan 24, 2018 at 2:31 PM, Michael Nazzareno Trimarchi >> wrote: >> >>> Can you check w

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi Fabio On Wed, Jan 24, 2018 at 5:38 PM, Fabio Estevam wrote: > Hi Michael, > > [Removed usb list as this is off-topic for them] > > On Wed, Jan 24, 2018 at 2:31 PM, Michael Nazzareno Trimarchi > wrote: > >> Can you check where SION bit is mandatory for mx25? I have on IMX51 >> some PINMUX wher

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Fabio Estevam
Hi Michael, [Removed usb list as this is off-topic for them] On Wed, Jan 24, 2018 at 2:31 PM, Michael Nazzareno Trimarchi wrote: > Can you check where SION bit is mandatory for mx25? I have on IMX51 > some PINMUX where sion is enabled. > I can clean up a bit the patch to just minimize the chang

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Benoît Thébaudeau
Hi, On 24/01/2018 at 17:17, Michael Nazzareno Trimarchi wrote: > On Wed, Jan 24, 2018 at 5:03 PM, Benoît Thébaudeau wrote: >> On 24/01/2018 at 16:43, Michael Nazzareno Trimarchi wrote: >>> On Wed, Jan 24, 2018 at 4:39 PM, Benoît Thébaudeau >>> wrote: On 24/01/2018 at 16:34, Benoît Thébaude

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi Fabio On Wed, Jan 24, 2018 at 4:26 PM, Michael Nazzareno Trimarchi wrote: > Hi Fabio > > On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam wrote: >> Hi Michael, >> Can you check where SION bit is mandatory for mx25? I have on IMX51 some PINMUX where sion is enabled. I can clean up a bit the pat

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi On Wed, Jan 24, 2018 at 5:03 PM, Benoît Thébaudeau wrote: > On 24/01/2018 at 16:43, Michael Nazzareno Trimarchi wrote: >> On Wed, Jan 24, 2018 at 4:39 PM, Benoît Thébaudeau >> wrote: >>> On 24/01/2018 at 16:34, Benoît Thébaudeau wrote: On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Benoît Thébaudeau
On 24/01/2018 at 16:43, Michael Nazzareno Trimarchi wrote: > On Wed, Jan 24, 2018 at 4:39 PM, Benoît Thébaudeau wrote: >> On 24/01/2018 at 16:34, Benoît Thébaudeau wrote: >>> On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi wrote: On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam wrote:

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi On Wed, Jan 24, 2018 at 4:39 PM, Benoît Thébaudeau wrote: > On 24/01/2018 at 16:34, Benoît Thébaudeau wrote: >> On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi wrote: >>> On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam wrote: On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi w

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Benoît Thébaudeau
On 24/01/2018 at 16:34, Benoît Thébaudeau wrote: > On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi wrote: >> On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam wrote: >>> On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi >>> wrote: SION bit should be used in the situation that we need

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Benoît Thébaudeau
Hi Michael, On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi wrote: > On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam wrote: >> On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi >> wrote: >>> SION bit should be used in the situation that we need >>> to read back the value of a pin and should

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Nazzareno Trimarchi
Hi Fabio On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam wrote: > Hi Michael, > > On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi > wrote: >> SION bit should be used in the situation that we need >> to read back the value of a pin and should be set by >> default. This can generate any kind of

Re: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Fabio Estevam
Hi Michael, On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi wrote: > SION bit should be used in the situation that we need > to read back the value of a pin and should be set by > default. This can generate any kind of random malfunction > as described in this thread. > > According to this th

[U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux

2018-01-24 Thread Michael Trimarchi
SION bit should be used in the situation that we need to read back the value of a pin and should be set by default. This can generate any kind of random malfunction as described in this thread. According to this thread: https://www.spinics.net/lists/linux-usb/msg162574.html We consider this an ea