Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command

2013-06-28 Thread Andy Fleming
On Thu, Jun 27, 2013 at 9:33 PM, Zhang Haijun-B42677 wrote: > Hi, Fleming > > ** ** > > I found the root cause. > > Our driver didn’t make a distinction between different board for this > register. (Just distinguish by esdhc version) > > On p1025 board watermark level was used both fo

Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command

2013-06-27 Thread Fabio Estevam
On Thu, Jun 27, 2013 at 11:06 PM, Zhang Haijun-B42677 wrote: > How about the read write command and erase command in your uboot with my > patch? > > I mean this: > mmcinfo > mmc read addr blk# cnt > mmc write addr blk# cnt > mmc erase blk# cnt > mmc rescan > mmc part - lists available partition o

Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command

2013-06-27 Thread Fabio Estevam
On Thu, Jun 27, 2013 at 11:00 PM, Zhang Haijun-B42677 wrote: > My board use DMA to transfer data by default. So we don't use > CONFIG_SYS_FSL_ESDHC_USE_PIO by default. > > Also my board works fine with PIO mode(with my patch). > > What about your board? Using PIO? We use DMA on i.MX. ___

Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command

2013-06-27 Thread Fabio Estevam
On Thu, Jun 27, 2013 at 6:50 AM, Zhang Haijun-B42677 wrote: > > Fabio, Did you boot up from sdcard? If so save command will write to SD card. > In this case write command will be failed. > I'm not familiar with mx6 system. I don't know if there are some difference > in Watermark Level Register (

Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command

2013-06-27 Thread Andy Fleming
On Thu, Jun 27, 2013 at 4:50 AM, Zhang Haijun-B42677 wrote: > Hi, Fleming and Fabio > > Sorry to reply to you so late. > > As our manual described. > > In the eSDHC, the data buffer can hold up to 128 words (32-bit). > > The watermark levels for both write and read can be configured for CPU > poll

Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command

2013-06-27 Thread Zhang Haijun-B42677
Hi, Fleming and Fabio Sorry to reply to you so late. As our manual described. In the eSDHC, the data buffer can hold up to 128 words (32-bit). The watermark levels for both write and read can be configured for CPU polling mode. The watermark level can be from 1 word to the maximum of 128 words

Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command

2013-05-28 Thread Fleming Andy-AFLEMING
On May 28, 2013, at 1:09 PM, Fabio Estevam wrote: > Since commit 48e0b2bd (powerpc/esdhc: Correct judgement for DATA PIO mode) > we see mx6 systems to hang after doing a 'save' command. > > Revert this commit since the original 'ifdef' logic from 7b43db92 > (drivers/mmc/fsl_esdhc.c: fix compil

Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command

2013-05-28 Thread Fabio Estevam
On Tue, May 28, 2013 at 3:31 PM, Otavio Salvador wrote: > This seem to affect 'master' branch, not 'imx' tree. Is that correct? Yes, the offending commit is in master, but not on u-boot-imx branch. ___ U-Boot mailing list U-Boot@lists.denx.de http://li

Re: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command

2013-05-28 Thread Otavio Salvador
On Tue, May 28, 2013 at 3:09 PM, Fabio Estevam wrote: > Since commit 48e0b2bd (powerpc/esdhc: Correct judgement for DATA PIO mode) > we see mx6 systems to hang after doing a 'save' command. > > Revert this commit since the original 'ifdef' logic from 7b43db92 > (drivers/mmc/fsl_esdhc.c: fix compil

[U-Boot] [PATCH] mmc: fsl_esdhc: Fix hang after 'save' command

2013-05-28 Thread Fabio Estevam
Since commit 48e0b2bd (powerpc/esdhc: Correct judgement for DATA PIO mode) we see mx6 systems to hang after doing a 'save' command. Revert this commit since the original 'ifdef' logic from 7b43db92 (drivers/mmc/fsl_esdhc.c: fix compiler warnings) was the correct one. Reported-by: Tapani Utriain