Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-29 Thread Stefano Babic
On 28/01/2012 23:08, Fabio Estevam wrote: > Hi Stefano, > > On Tue, Jan 24, 2012 at 6:40 AM, Stefano Babic wrote: > >> Applied to u-boot-imx, thanks. > Hi Fabio, > Which branch, please? > > I am not able to find it. Sorry, I have not yet pushed to the server - done now. Best regards, Stefa

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-28 Thread Fabio Estevam
Hi Stefano, On Tue, Jan 24, 2012 at 6:40 AM, Stefano Babic wrote: > Applied to u-boot-imx, thanks. Which branch, please? I am not able to find it. Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/list

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-24 Thread Stefano Babic
On 14/01/2012 13:25, Matthias Fuchs wrote: > The generic spi flash driver (drivers/mtd/spi/spi_flash.c) uses the > spi low level driver's spi_xfer() function with len=0 to deassert the > SPI flash' chip select. But the i.MX28 spi driver rejects this call > due to len=0. > > This patch implements a

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-23 Thread Marek Vasut
> On 1/14/12, Matthias Fuchs wrote: > > The generic spi flash driver (drivers/mtd/spi/spi_flash.c) uses the > > spi low level driver's spi_xfer() function with len=0 to deassert the > > SPI flash' chip select. But the i.MX28 spi driver rejects this call > > due to len=0. > > > > This patch implem

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-23 Thread Fabio Estevam
On 1/14/12, Matthias Fuchs wrote: > The generic spi flash driver (drivers/mtd/spi/spi_flash.c) uses the > spi low level driver's spi_xfer() function with len=0 to deassert the > SPI flash' chip select. But the i.MX28 spi driver rejects this call > due to len=0. > > This patch implements an excepti

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-17 Thread Fabio Estevam
On 1/16/12, Alexander Keller wrote: > I just want to confirm and thanks to Matthias for this patch. I already > stated my problems by writing the SPI flash ... > > So, I use the IMX28EVK with a Winbond W25Q64CV SPI flash chip and it's > working great now. > > Thanks for the great work. Ok, great

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-16 Thread Alexander Keller
> On 01/14/2012 03:10 PM, Marek Vasut wrote: > >> The generic spi flash driver (drivers/mtd/spi/spi_flash.c) uses the > >> spi low level driver's spi_xfer() function with len=0 to deassert the > >> SPI flash' chip select. But the i.MX28 spi driver rejects this call > >> due to len=0. > >> > >> This

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-15 Thread Matthias Fuchs
On 01/15/2012 04:28 PM, Fabio Estevam wrote: > On Sun, Jan 15, 2012 at 10:10 AM, Matthias Fuchs > wrote: > >> That's what I also tried. But from the ref manual I got no idea. >> When we do not find a hy to deassert the chip select manually, we cannot >> avoid this read. > > I was assuming that

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-15 Thread Fabio Estevam
On Sun, Jan 15, 2012 at 10:10 AM, Matthias Fuchs wrote: > That's what I also tried. But from the ref manual I got no idea. > When we do not find a hy to deassert the chip select manually, we cannot > avoid this read. I was assuming that the chip select deassertion was correctly being handled by

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-15 Thread Matthias Fuchs
On 01/14/2012 09:14 PM, Fabio Estevam wrote: > On Sat, Jan 14, 2012 at 6:09 PM, Matthias Fuchs wrote: >> This cannot work. I do not understand what you are trying to achieve with >> this. > > I would like to avoid the extra dummy read that your patch proposes. That's what I also tried. But from

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-14 Thread Fabio Estevam
On Sat, Jan 14, 2012 at 6:09 PM, Matthias Fuchs wrote: > This cannot work. I do not understand what you are trying to achieve with > this. I would like to avoid the extra dummy read that your patch proposes. ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-14 Thread Matthias Fuchs
This cannot work. I do not understand what you are trying to achieve with this. Matthias On 01/14/2012 07:54 PM, Fabio Estevam wrote: > On Sat, Jan 14, 2012 at 4:53 PM, Fabio Estevam wrote: > >> Actually I meant this: > > One more time ;-) > > --- a/drivers/spi/mxs_spi.c > +++ b/drivers/spi/m

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-14 Thread Fabio Estevam
On Sat, Jan 14, 2012 at 4:53 PM, Fabio Estevam wrote: > Actually I meant this: One more time ;-) --- a/drivers/spi/mxs_spi.c +++ b/drivers/spi/mxs_spi.c @@ -130,13 +130,10 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const char *tx = dout; char *rx = din; -

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-14 Thread Fabio Estevam
On Sat, Jan 14, 2012 at 4:46 PM, Fabio Estevam wrote: > Hi Matthias, > > On Sat, Jan 14, 2012 at 10:25 AM, Matthias Fuchs > wrote: >> The generic spi flash driver (drivers/mtd/spi/spi_flash.c) uses the >> spi low level driver's spi_xfer() function with len=0 to deassert the >> SPI flash' chip se

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-14 Thread Fabio Estevam
Hi Matthias, On Sat, Jan 14, 2012 at 10:25 AM, Matthias Fuchs wrote: > The generic spi flash driver (drivers/mtd/spi/spi_flash.c) uses the > spi low level driver's spi_xfer() function with len=0 to deassert the > SPI flash' chip select. But the i.MX28 spi driver rejects this call > due to len=0.

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-14 Thread Matthias Fuchs
On 01/14/2012 03:10 PM, Marek Vasut wrote: >> The generic spi flash driver (drivers/mtd/spi/spi_flash.c) uses the >> spi low level driver's spi_xfer() function with len=0 to deassert the >> SPI flash' chip select. But the i.MX28 spi driver rejects this call >> due to len=0. >> >> This patch impleme

Re: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-14 Thread Marek Vasut
> The generic spi flash driver (drivers/mtd/spi/spi_flash.c) uses the > spi low level driver's spi_xfer() function with len=0 to deassert the > SPI flash' chip select. But the i.MX28 spi driver rejects this call > due to len=0. > > This patch implements an exception for len=0 with the SPI_XFER_END

[U-Boot] [PATCH] mx28: fix i.MX28 spi driver

2012-01-14 Thread Matthias Fuchs
The generic spi flash driver (drivers/mtd/spi/spi_flash.c) uses the spi low level driver's spi_xfer() function with len=0 to deassert the SPI flash' chip select. But the i.MX28 spi driver rejects this call due to len=0. This patch implements an exception for len=0 with the SPI_XFER_END flag set. T