Re: [U-Boot] [PATCH] net: zynq_gem: Return 0 on success, not -ENOSYS

2016-12-02 Thread Olliver Schinagl
Hey Joe, On 01-12-16 00:38, Joe Hershberger wrote: On Fri, Nov 25, 2016 at 9:41 AM, Olliver Schinagl wrote: The .read_rom_hwaddr net_ops hook does not check the return value, which is why it was never caught that we are currently returning 0 if the read_rom_hwaddr

Re: [U-Boot] [PATCH] net: zynq_gem: Return 0 on success, not -ENOSYS

2016-11-30 Thread Joe Hershberger
On Fri, Nov 25, 2016 at 9:41 AM, Olliver Schinagl wrote: > The .read_rom_hwaddr net_ops hook does not check the return value, which > is why it was never caught that we are currently returning 0 if the > read_rom_hwaddr function return -ENOSYS and -ENOSYS otherwise. > > In

Re: [U-Boot] [PATCH] net: zynq_gem: Return 0 on success, not -ENOSYS

2016-11-28 Thread Olliver Schinagl
On 28-11-16 08:22, Michal Simek wrote: On 25.11.2016 16:41, Olliver Schinagl wrote: The .read_rom_hwaddr net_ops hook does not check the return value, which is why it was never caught that we are currently returning 0 if the read_rom_hwaddr function return -ENOSYS and -ENOSYS otherwise. In

Re: [U-Boot] [PATCH] net: zynq_gem: Return 0 on success, not -ENOSYS

2016-11-27 Thread Michal Simek
On 25.11.2016 16:41, Olliver Schinagl wrote: > The .read_rom_hwaddr net_ops hook does not check the return value, which > is why it was never caught that we are currently returning 0 if the > read_rom_hwaddr function return -ENOSYS and -ENOSYS otherwise. > > In this case we can simplify this by

[U-Boot] [PATCH] net: zynq_gem: Return 0 on success, not -ENOSYS

2016-11-25 Thread Olliver Schinagl
The .read_rom_hwaddr net_ops hook does not check the return value, which is why it was never caught that we are currently returning 0 if the read_rom_hwaddr function return -ENOSYS and -ENOSYS otherwise. In this case we can simplify this by just returning the result of the function.