Re: [U-Boot] [PATCH] pinctrl: rockchip: Add 32bit writing function for rk3288 gpio0 pinctrl

Hi Philipp, 在 2019/3/29 下午10:40, Philipp Tomsich 写道: David, I am applying this one as a last-minute fix for 2019.4. However, I’ll still need the v2 for the next cycle, as I my review comments still apply. Sorry, there was a lot of things in March. I think I could push v2 at this week.

Re: [U-Boot] [PATCH] pinctrl: rockchip: Add 32bit writing function for rk3288 gpio0 pinctrl

David, I am applying this one as a last-minute fix for 2019.4. However, I’ll still need the v2 for the next cycle, as I my review comments still apply. Thanks, Philipp. > On 12.02.2019, at 12:55, Philipp Tomsich > wrote: > > > >> On 12.02.2019, at 12:51, David Wu wrote: >> >> There are

Re: [U-Boot] [PATCH] pinctrl: rockchip: Add 32bit writing function for rk3288 gpio0 pinctrl

> On 12.02.2019, at 12:51, David Wu wrote: > > There are no higher 16 writing corresponding bits for pmu_gpio0's > iomux/drive/pull at rk3288, need to read the value from register > firstly. Add the flag to distinguish it from normal registers. > > Signed-off-by: David Wu > --- >

[U-Boot] [PATCH] pinctrl: rockchip: Add 32bit writing function for rk3288 gpio0 pinctrl

There are no higher 16 writing corresponding bits for pmu_gpio0's iomux/drive/pull at rk3288, need to read the value from register firstly. Add the flag to distinguish it from normal registers. Signed-off-by: David Wu --- drivers/pinctrl/rockchip/pinctrl-rk3288.c | 17 ++--