Re: [U-Boot] [PATCH] powerpc/corenet_ds: move SATA config to board configuration

2012-11-02 Thread Zang Roy-R61911
-Original Message- From: Tabi Timur-B04825 Sent: Friday, November 02, 2012 12:25 AM To: Tabi Timur-B04825 Cc: Zang Roy-R61911; u-boot@lists.denx.de; aflem...@gmail.com Subject: Re: [U-Boot] [PATCH] powerpc/corenet_ds: move SATA config to board configuration On Thu, Nov 1, 2012

[U-Boot] [PATCH] powerpc/corenet_ds: move SATA config to board configuration

2012-11-01 Thread Roy Zang
board configuration file is included before asm/config_mpc85xx.h. however, CONFIG_FSL_SATA_V2 is defined in asm/config_mpc85xx.h. it will never take effective in the board configuration file for this kind of code : #ifdef CONFIG_FSL_SATA_V2 ... #endif To solve this problem, move

Re: [U-Boot] [PATCH] powerpc/corenet_ds: move SATA config to board configuration

2012-11-01 Thread Tabi Timur-B04825
On Thu, Nov 1, 2012 at 3:13 AM, Roy Zang tie-fei.z...@freescale.com wrote: board configuration file is included before asm/config_mpc85xx.h. however, CONFIG_FSL_SATA_V2 is defined in asm/config_mpc85xx.h. it will never take effective in the board configuration file for this kind of code :

Re: [U-Boot] [PATCH] powerpc/corenet_ds: move SATA config to board configuration

2012-11-01 Thread Tabi Timur-B04825
On Thu, Nov 1, 2012 at 11:20 AM, Tabi Timur-B04825 b04...@freescale.com wrote: To solve this problem, move CONFIG_FSL_SATA_V2 to board configuration header file. http://patchwork.ozlabs.org/patch/126958/ To be clear, I think you should say in the patch description that your patch effectively