Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2020-01-16 Thread Tom Rini
On Thu, Jan 16, 2020 at 03:46:15PM +0100, Giulio Benetti wrote: > Hi Tom, > > +Stefano B. > > On 1/16/20 3:40 PM, Tom Rini wrote: > > On Mon, Nov 25, 2019 at 05:18:20PM +0100, Giulio Benetti wrote: > > > > > At the moment entry_point is set to image_get_load(header) that sets it > > > to "load

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2020-01-16 Thread Giulio Benetti
Hi Tom, +Stefano B. On 1/16/20 3:40 PM, Tom Rini wrote: On Mon, Nov 25, 2019 at 05:18:20PM +0100, Giulio Benetti wrote: At the moment entry_point is set to image_get_load(header) that sets it to "load address" instead of "entry point", assuming entry_point is equal to load_addr, but it's not

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2020-01-16 Thread Tom Rini
On Mon, Nov 25, 2019 at 05:18:20PM +0100, Giulio Benetti wrote: > At the moment entry_point is set to image_get_load(header) that sets it > to "load address" instead of "entry point", assuming entry_point is > equal to load_addr, but it's not true. Then load_addr is set to > "entry_point -

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2020-01-10 Thread Tom Rini
On Fri, Jan 10, 2020 at 03:57:47PM +0100, Giulio Benetti wrote: > Hi All, > > On 12/7/19 10:28 PM, Simon Goldschmidt wrote: > > Hi Tom, > > > > On Fri, Dec 6, 2019 at 3:55 PM Tom Rini wrote: > > > > > > On Fri, Dec 06, 2019 at 03:05:55PM +0100, Simon Goldschmidt wrote: > > > > On Fri, Dec 6,

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2020-01-10 Thread Giulio Benetti
Hi All, On 12/7/19 10:28 PM, Simon Goldschmidt wrote: Hi Tom, On Fri, Dec 6, 2019 at 3:55 PM Tom Rini wrote: On Fri, Dec 06, 2019 at 03:05:55PM +0100, Simon Goldschmidt wrote: On Fri, Dec 6, 2019 at 2:49 PM Giulio Benetti wrote: Hello Tom, all, On 12/6/19 2:34 PM, Tom Rini wrote: On

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-12-07 Thread Simon Goldschmidt
Hi Tom, On Fri, Dec 6, 2019 at 3:55 PM Tom Rini wrote: > > On Fri, Dec 06, 2019 at 03:05:55PM +0100, Simon Goldschmidt wrote: > > On Fri, Dec 6, 2019 at 2:49 PM Giulio Benetti > > wrote: > > > > > > Hello Tom, all, > > > > > > On 12/6/19 2:34 PM, Tom Rini wrote: > > > > On Fri, Dec 06, 2019 at

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-12-06 Thread Giulio Benetti
Hi Patrice, On 12/6/19 3:04 PM, Patrice CHOTARD wrote: So probably broken boards try to jump to absolute 0. A solving patch would be: ifndef CONFIG_SYS_UBOOT_START CONFIG_SYS_UBOOT_START := CONFIG_SYS_TEXT_BASE endif What do you think? This is what i implemented to fix this issue. Here is my

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-12-06 Thread Tom Rini
On Fri, Dec 06, 2019 at 03:05:55PM +0100, Simon Goldschmidt wrote: > On Fri, Dec 6, 2019 at 2:49 PM Giulio Benetti > wrote: > > > > Hello Tom, all, > > > > On 12/6/19 2:34 PM, Tom Rini wrote: > > > On Fri, Dec 06, 2019 at 01:58:46PM +0100, Simon Goldschmidt wrote: > > >> On Fri, Dec 6, 2019 at

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-12-06 Thread Simon Goldschmidt
On Fri, Dec 6, 2019 at 2:49 PM Giulio Benetti wrote: > > Hello Tom, all, > > On 12/6/19 2:34 PM, Tom Rini wrote: > > On Fri, Dec 06, 2019 at 01:58:46PM +0100, Simon Goldschmidt wrote: > >> On Fri, Dec 6, 2019 at 1:46 PM Patrice CHOTARD > >> wrote: > >>> > >>> Hi > >>> > >>> This patch is

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-12-06 Thread Patrice CHOTARD
Hi All On 12/6/19 2:48 PM, Giulio Benetti wrote: > Hello Tom, all, > > On 12/6/19 2:34 PM, Tom Rini wrote: >> On Fri, Dec 06, 2019 at 01:58:46PM +0100, Simon Goldschmidt wrote: >>> On Fri, Dec 6, 2019 at 1:46 PM Patrice CHOTARD >>> wrote: Hi This patch is breaking the

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-12-06 Thread Giulio Benetti
Hello Tom, all, On 12/6/19 2:34 PM, Tom Rini wrote: On Fri, Dec 06, 2019 at 01:58:46PM +0100, Simon Goldschmidt wrote: On Fri, Dec 6, 2019 at 1:46 PM Patrice CHOTARD wrote: Hi This patch is breaking the STM32MP15 basic boot (spl => u-boot). Looking at socfpga gen5 u-boot.img, this is

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-12-06 Thread Tom Rini
On Fri, Dec 06, 2019 at 02:37:52PM +0100, Simon Goldschmidt wrote: > On Fri, Dec 6, 2019 at 2:34 PM Tom Rini wrote: > > > > On Fri, Dec 06, 2019 at 01:58:46PM +0100, Simon Goldschmidt wrote: > > > On Fri, Dec 6, 2019 at 1:46 PM Patrice CHOTARD > > > wrote: > > > > > > > > Hi > > > > > > > >

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-12-06 Thread Simon Goldschmidt
On Fri, Dec 6, 2019 at 2:34 PM Tom Rini wrote: > > On Fri, Dec 06, 2019 at 01:58:46PM +0100, Simon Goldschmidt wrote: > > On Fri, Dec 6, 2019 at 1:46 PM Patrice CHOTARD > > wrote: > > > > > > Hi > > > > > > This patch is breaking the STM32MP15 basic boot (spl => u-boot). > > > > Looking at

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-12-06 Thread Tom Rini
On Fri, Dec 06, 2019 at 01:58:46PM +0100, Simon Goldschmidt wrote: > On Fri, Dec 6, 2019 at 1:46 PM Patrice CHOTARD wrote: > > > > Hi > > > > This patch is breaking the STM32MP15 basic boot (spl => u-boot). > > Looking at socfpga gen5 u-boot.img, this is probably broken as well. > > And I don't

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-12-06 Thread Simon Goldschmidt
On Fri, Dec 6, 2019 at 1:46 PM Patrice CHOTARD wrote: > > Hi > > This patch is breaking the STM32MP15 basic boot (spl => u-boot). Looking at socfpga gen5 u-boot.img, this is probably broken as well. And I don't even see any RB or TB tags here :-( Regards, Simon > > I will send a fix proposal.

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-12-06 Thread Patrice CHOTARD
Hi This patch is breaking the STM32MP15 basic boot (spl => u-boot). I will send a fix proposal. Thanks Patrice On 12/5/19 11:09 PM, Tom Rini wrote: > On Mon, Nov 25, 2019 at 05:18:20PM +0100, Giulio Benetti wrote: > >> At the moment entry_point is set to image_get_load(header) that sets it >>

Re: [U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-12-05 Thread Tom Rini
On Mon, Nov 25, 2019 at 05:18:20PM +0100, Giulio Benetti wrote: > At the moment entry_point is set to image_get_load(header) that sets it > to "load address" instead of "entry point", assuming entry_point is > equal to load_addr, but it's not true. Then load_addr is set to > "entry_point -

[U-Boot] [PATCH] spl: fix entry_point equal to load_addr

2019-11-25 Thread Giulio Benetti
At the moment entry_point is set to image_get_load(header) that sets it to "load address" instead of "entry point", assuming entry_point is equal to load_addr, but it's not true. Then load_addr is set to "entry_point - header_size", but this is wrong too since load_addr is not an entry point. So