Re: [U-Boot] [PATCH] sunxi: musb: Re-init musb controller on repeated probe calls

2016-09-18 Thread Hans de Goede
Hi, On 18-09-16 17:00, Ian Campbell wrote: On Sun, 2016-09-18 at 16:53 +0200, Hans de Goede wrote: With sunxi-musb musb_lowlevel_init() can fail when a charger; or no cable is plugged into the otg port. To avoid leaking the struct musb allocated by musb_init_controller() on repeated

Re: [U-Boot] [PATCH] sunxi: musb: Re-init musb controller on repeated probe calls

2016-09-18 Thread Ian Campbell
On Sun, 2016-09-18 at 16:53 +0200, Hans de Goede wrote: > With sunxi-musb musb_lowlevel_init() can fail when a charger; or no > cable > is plugged into the otg port. > > To avoid leaking the struct musb allocated by musb_init_controller() > on repeated musb_usb_probe() calls, we were caching its

[U-Boot] [PATCH] sunxi: musb: Re-init musb controller on repeated probe calls

2016-09-18 Thread Hans de Goede
With sunxi-musb musb_lowlevel_init() can fail when a charger; or no cable is plugged into the otg port. To avoid leaking the struct musb allocated by musb_init_controller() on repeated musb_usb_probe() calls, we were caching its result. But musb_init_controller() does more, such as calling