Re: [U-Boot] [PATCH] video: cfb_console: fix definition and usage of CURSOR_xxx macros

2010-08-30 Thread Detlev Zundel
Hi Timur, The CURSOR_ON, CURSOR_OFF, and CURSOR_SET macros are defined incorrectly. If cursor support is disabled, then these macros are defined to nothing, but then they are used like this: if (console_col CONSOLE_COLS) CURSOR_OFF console_row++; which was

Re: [U-Boot] [PATCH] video: cfb_console: fix definition and usage of CURSOR_xxx macros

2010-08-30 Thread Anatolij Gustschin
On Fri, 27 Aug 2010 15:45:47 -0500 Timur Tabi ti...@freescale.com wrote: The CURSOR_ON, CURSOR_OFF, and CURSOR_SET macros are defined incorrectly. If cursor support is disabled, then these macros are defined to nothing, but then they are used like this: if (console_col CONSOLE_COLS)

[U-Boot] [PATCH] video: cfb_console: fix definition and usage of CURSOR_xxx macros

2010-08-27 Thread Timur Tabi
The CURSOR_ON, CURSOR_OFF, and CURSOR_SET macros are defined incorrectly. If cursor support is disabled, then these macros are defined to nothing, but then they are used like this: if (console_col CONSOLE_COLS) CURSOR_OFF console_row++; which was compiled like