Re: [U-Boot] [PATCH] x86: Simplify the fsp hob access functions

2014-12-31 Thread Bin Meng
Hi Simon, On Wed, Dec 31, 2014 at 7:02 AM, Simon Glass s...@chromium.org wrote: Hi Bin, On 30 December 2014 at 01:02, Bin Meng bmeng...@gmail.com wrote: Remove the troublesome union hob_pointers so that some annoying casts are no longer needed in those hob access routines. This also improves

Re: [U-Boot] [PATCH] x86: Simplify the fsp hob access functions

2014-12-31 Thread Simon Glass
On 31 December 2014 at 01:22, Bin Meng bmeng...@gmail.com wrote: Hi Simon, On Wed, Dec 31, 2014 at 7:02 AM, Simon Glass s...@chromium.org wrote: Hi Bin, On 30 December 2014 at 01:02, Bin Meng bmeng...@gmail.com wrote: Remove the troublesome union hob_pointers so that some annoying casts

[U-Boot] [PATCH] x86: Simplify the fsp hob access functions

2014-12-30 Thread Bin Meng
Remove the troublesome union hob_pointers so that some annoying casts are no longer needed in those hob access routines. This also improves the readability. Signed-off-by: Bin Meng bmeng...@gmail.com --- arch/x86/cpu/queensbay/fsp_support.c | 95 --

Re: [U-Boot] [PATCH] x86: Simplify the fsp hob access functions

2014-12-30 Thread Simon Glass
Hi Bin, On 30 December 2014 at 01:02, Bin Meng bmeng...@gmail.com wrote: Remove the troublesome union hob_pointers so that some annoying casts are no longer needed in those hob access routines. This also improves the readability. Signed-off-by: Bin Meng bmeng...@gmail.com ---