Re: [U-Boot] [PATCH 06/14] powerpc/corenet_ds: Add fman support

2011-01-27 Thread Timur Tabi
Mingkai Hu wrote: +enum board_slots { + SLOT1 = 1, + SLOT2, + SLOT3, + SLOT4, + SLOT5, + SLOT6, +}; This is silly. SLOT1 == 1, SLOT2 == 2, etc. Just delete this enum and use numbers. -- Timur Tabi Linux kernel developer at Freescale

[U-Boot] [PATCH 06/14] powerpc/corenet_ds: Add fman support

2011-01-26 Thread Mingkai Hu
From: Kumar Gala ga...@kernel.crashing.org Signed-off-by: Kumar Gala ga...@kernel.crashing.org Signed-off-by: Mingkai Hu mingkai...@freescale.com --- board/freescale/corenet_ds/Makefile |1 + board/freescale/corenet_ds/corenet_ds.c | 11 +- board/freescale/corenet_ds/eth_p4080.c |