Re: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support

2008-10-07 Thread Nishanth Menon
Dirk Behme said the following on 10/07/2008 04:42 AM: Scott Wood wrote: On Fri, Oct 03, 2008 at 12:40:25PM +0200, [EMAIL PROTECTED] wrote: +#include common.h +#include asm/io.h +#include asm/arch/mem.h +#include linux/mtd/nand_ecc.h + +#if defined(CONFIG_CMD_NAND) + +#include nand.h

Re: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support

2008-10-07 Thread Dirk Behme
Unfortunately, except Nishanth's comments, I didn't get any further help (e.g. from TI) for this yet. So I started to look at this myself. Please forgive everything I missed as I'm no NAND expert. Maybe you like to explain some additional details regarding what I missed ;) First version of

Re: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support

2008-10-07 Thread Scott Wood
On Tue, Oct 07, 2008 at 11:42:38AM +0200, Dirk Behme wrote: Is it OK if config gets written before control, or if this whole thing gets done out of order with respect to other raw writes? Hmm. I replaced this with the version from Nishanth's U-Boot v2 (see link above). If this isn't ok, can

Re: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support

2008-10-07 Thread Scott Wood
On Tue, Oct 07, 2008 at 06:25:11AM -0500, Nishanth Menon wrote: Dirk Behme said the following on 10/07/2008 04:42 AM: It doesn't differ ;) So I removed this and tried to use default nand_read_buf16() instead: nand-read_buf = nand_read_buf16; in board_nand_init(). But this doesn't

Re: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support

2008-10-07 Thread Scott Wood
Menon, Nishanth wrote: I do not get it either.. ECCPOS is in offset bytes, and oobfree should be {.offset=20,.length=44} /*I always hated struct initialization done as above..*/, but then, Why not offset 14, length 50? How about this part being used by ubi/jffs2 or some fs.. I cant think

Re: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support

2008-10-07 Thread Dirk Behme
Scott Wood wrote: On Tue, Oct 07, 2008 at 11:42:38AM +0200, Dirk Behme wrote: Is it OK if config gets written before control, or if this whole thing gets done out of order with respect to other raw writes? Hmm. I replaced this with the version from Nishanth's U-Boot v2 (see link above). If

Re: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support

2008-10-07 Thread Dirk Behme
Scott Wood wrote: On Tue, Oct 07, 2008 at 06:25:11AM -0500, Nishanth Menon wrote: Dirk Behme said the following on 10/07/2008 04:42 AM: It doesn't differ ;) So I removed this and tried to use default nand_read_buf16() instead: nand-read_buf = nand_read_buf16; in board_nand_init(). But this

Re: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support

2008-10-07 Thread Menon, Nishanth
-Original Message- From: Scott Wood [mailto:[EMAIL PROTECTED] Sent: Tuesday, October 07, 2008 12:30 PM To: Nishanth Menon Cc: Dirk Behme; u-boot@lists.denx.de; Kamat, Nishant; Menon, Nishanth Subject: Re: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add

Re: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support

2008-10-07 Thread Scott Wood
Dirk Behme wrote: Otherwise, either add something to the MTD API that the nand command can call, or have your own board-specific command defined in the board file. Don't put platform-specific ifdefs in generic files. Do you have any example how to extend MTD API You'd need to add callbacks

[U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support

2008-10-03 Thread dirk . behme
Subject: [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support From: Dirk Behme [EMAIL PROTECTED] Add memory and syslib common files, add NAND support Signed-off-by: Dirk Behme [EMAIL PROTECTED] --- Changes in version v2: - Move common ARM Cortex A8 code to

Re: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support

2008-10-03 Thread Scott Wood
On Fri, Oct 03, 2008 at 12:40:25PM +0200, [EMAIL PROTECTED] wrote: +#include common.h +#include asm/io.h +#include asm/arch/mem.h +#include linux/mtd/nand_ecc.h + +#if defined(CONFIG_CMD_NAND) + +#include nand.h Move the #ifdef to the Makefile. +/* + * nand_read_buf16 - [DEFAULT] read