Re: [U-Boot] [PATCH 07/15] x86: Add functions to access MSRs

2012-11-03 Thread Simon Glass
Hi Graeme, On Wed, Oct 24, 2012 at 3:22 PM, Graeme Russ graeme.r...@gmail.com wrote: Hi Stefan, On Thu, Oct 25, 2012 at 8:15 AM, Stefan Reinauer reina...@google.com wrote: Graeme, Reusing code from the Linux kernel is generally a great idea. However for simplicity I'd rather have 25 lines

Re: [U-Boot] [PATCH 07/15] x86: Add functions to access MSRs

2012-10-25 Thread Stefan Reinauer
Graeme, Reusing code from the Linux kernel is generally a great idea. However for simplicity I'd rather have 25 lines than 870 lines for reading MSRs. It seems a lot of code in those files doesn't really apply for u-boot Stefan On Tue, Oct 23, 2012 at 9:34 PM, Graeme Russ graeme.r...@gmail.com

Re: [U-Boot] [PATCH 07/15] x86: Add functions to access MSRs

2012-10-24 Thread Graeme Russ
Hi Stefan, On Thu, Oct 25, 2012 at 8:15 AM, Stefan Reinauer reina...@google.com wrote: Graeme, Reusing code from the Linux kernel is generally a great idea. However for simplicity I'd rather have 25 lines than 870 lines for reading MSRs. It seems a lot of code in those files doesn't really

[U-Boot] [PATCH 07/15] x86: Add functions to access MSRs

2012-10-23 Thread Simon Glass
From: Stefan Reinauer reina...@chromium.org Provide basic functions to access these registers. Signed-off-by: Stefan Reinauer reina...@chromium.org Signed-off-by: Simon Glass s...@chromium.org --- arch/x86/include/asm/msr.h | 25 + 1 files changed, 25 insertions(+), 0

Re: [U-Boot] [PATCH 07/15] x86: Add functions to access MSRs

2012-10-23 Thread Graeme Russ
Hi Simon, On Wed, Oct 24, 2012 at 3:04 PM, Simon Glass s...@chromium.org wrote: From: Stefan Reinauer reina...@chromium.org Provide basic functions to access these registers. I really should have got my funk into gear and posted patches I created (on a side project) a long time ago :(