Re: [U-Boot] [PATCH 1/1] env: Exit tools when invalid CRC found

2019-11-25 Thread Wolfgang Denk
Dear Joe, In message you wrote: > > On Tue, May 7, 2019 at 10:21 AM Molloy, Philip > wrote: > > > > On Sun, 2019-05-05 at 08:50 -0400, Tom Rini wrote: > > > Conceptually, yes, this is correct. However, the behavior in > > > question > > > has been deployed for so long that I don't feel that

Re: [U-Boot] [PATCH 1/1] env: Exit tools when invalid CRC found

2019-11-19 Thread Tom Rini
On Tue, Nov 19, 2019 at 06:06:27PM -0600, Joe Hershberger wrote: > Hi Tom, > > On Tue, May 7, 2019 at 10:21 AM Molloy, Philip > wrote: > > > > On Sun, 2019-05-05 at 08:50 -0400, Tom Rini wrote: > > > Conceptually, yes, this is correct. However, the behavior in > > > question > > > has been

Re: [U-Boot] [PATCH 1/1] env: Exit tools when invalid CRC found

2019-11-19 Thread Joe Hershberger
Hi Tom, On Tue, May 7, 2019 at 10:21 AM Molloy, Philip wrote: > > On Sun, 2019-05-05 at 08:50 -0400, Tom Rini wrote: > > Conceptually, yes, this is correct. However, the behavior in > > question > > has been deployed for so long that I don't feel that we can change it > > at > > this point, so

Re: [U-Boot] [PATCH 1/1] env: Exit tools when invalid CRC found

2019-05-07 Thread Molloy, Philip
On Sun, 2019-05-05 at 08:50 -0400, Tom Rini wrote: > Conceptually, yes, this is correct. However, the behavior in > question > has been deployed for so long that I don't feel that we can change it > at > this point, so I'm going to NAK this. Sorry. I certainly understand that constraint even

Re: [U-Boot] [PATCH 1/1] env: Exit tools when invalid CRC found

2019-05-05 Thread Tom Rini
On Wed, Apr 03, 2019 at 01:30:47PM +, Molloy, Philip wrote: > fw_setenv and fw_printenv currently print a warning and use a default > environment compiled into the binary when an invalid CRC is found. This > modifies the default behavior to print an error and exit. This is > especially

[U-Boot] [PATCH 1/1] env: Exit tools when invalid CRC found

2019-04-03 Thread Molloy, Philip
fw_setenv and fw_printenv currently print a warning and use a default environment compiled into the binary when an invalid CRC is found. This modifies the default behavior to print an error and exit. This is especially important when calling the tools from a script since the script depends on the